Edit ADRIA.Domain() and generalize to incorporate loading of GBR-wide domain package #904
Conversation
There was a problem hiding this comment.
The location of the geopackage is correctly documented in the datapackage.json file, how load_domain does not currently use this. This causes an error during load_domain.
ERROR: Provided location data path is not valid or missing: C:/Users/dtan/data/GBR_2024_10_15\spatial\GBR_2024_10_15.gpkg.
Stacktrace:Note: This Line, ADRIA currently uses the name of the directory as the name of the geopackage, this should be changed to use the path provided in datapackage.json.
This information is stored in the Moore Domain, however the most recent version v070_rc1 incorrectly lists the spatial gpkg as v060_rc1
| # ReefMod DHW timeseries data (2000:2100) do not match the length of waves/cyclone | ||
| # data (2025:2099). Can be fixed when AIMS-sourced DHW trajectories become available. |
There was a problem hiding this comment.
| # ReefMod DHW timeseries data (2000:2100) do not match the length of waves/cyclone | |
| # data (2025:2099). Can be fixed when AIMS-sourced DHW trajectories become available. | |
| # ReefMod DHW timeseries data (2000:2100) do not match the length of waves/cyclone | |
| # data (2025:2099). Can be fixed when AIMS-sourced DHW trajectories become available. |
Whitespace
src/ExtInterface/ADRIA/Domain.jl
Outdated
| location_data.k .= location_data.k / 100.0 # Make `k` non-dimensional (provided as a percent) | ||
| if ("k" ∉ names(location_data)) & | ||
| ("ReefMod_habitable_proportion" ∈ names(location_data)) | ||
| # k column not found in gbr-wide canonical-reefs gpkg. |
There was a problem hiding this comment.
| # k column not found in gbr-wide canonical-reefs gpkg. | |
| # k column not found in gbr-wide canonical-reefs gpkg. |
There was a problem hiding this comment.
Some ADRIA functions assumes the column area exists in the geopackage dataframe. The canonical reefs gpkg currently labels this column as ReefMod_area_m2. This prevents the model from running.
ERROR: ArgumentError: column name :area not found in the data frame
Minor changes required to generalize code away from reef cluster/site level Domains and allow GBR-wide ADRIADomains to be accepted.