/ui2/cl_json: add inherit functionality

[oblomov-dev]

open-abap is not working when a class inherits /ui2/json:
https://github.com/abap2UI5/abap2UI5/actions/runs/7583976799/job/20656717865?pr=793

added:

• constructor
• is_compressable
• serialize_int (and added the code of the serialize method)
• added attributes used in the constructor

next step / issue:

• adjusting serialize_int with respecting the value mv_extended.

I have no idea if this inheriting concept is easily implementable in open-abap? before i start making changes here without knowing how this all specifically works, maybe its better you comment on this first.

[larshp]

inheritance should work in open-abap, so all good

[larshp]

@oblomov-dev if you dont have vscode installed, you can try https://github.com/github/dev, it might be easier

[oblomov-dev]

yes github codespaces (i think it is the same) is my second home after eclipse :) i will check it!

[oblomov-dev]

ok, fixed all the linter issues now, all tests are green.

i skipped implementing the call of the "is_compressable" method, means from my understanding: you can inherit /ui2/cl_json now but when you create a unit test based on a change implemented in is_compressable, open-abap will give a different result than the normal abap stack but maybe for the first step, this is enough.

[larshp]

see comments

[oblomov-dev]

see this review and comment function for the first time, nice! code is adjusted.

[larshp]

thanks 👍

[larshp]

if the compress inheritance and stuff doesnt work, suggest as next step adding a unit test for it in https://github.com/oblomov-dev/open-abap-core/blob/main/src/json/%23ui2%23cl_json.clas.testclasses.abap

[oblomov-dev]

@larshp
ok, would there also be the chance to debug the code? can i for example rename it to zui2_cl_json, copy it to an abap stack and run the unit tests or what is the recommended way?

[larshp]

that might work

typically I dont debug much, when there is a simple unit test for it its easy to find the bug

standalone debuggin also works a bit,

[oblomov-dev]

ah ok interesting, i will try it out :)