Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(db): align variable names for limit and offset #1068

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Conversation

rsdmike
Copy link
Member

@rsdmike rsdmike commented Sep 14, 2023

This is not a breaking change despite the variable names changing in the interface/implementation as typescript doesn't enforce the parameter names.

PR Checklist

  • Unit Tests have been added for new changes
  • API tests have been updated if applicable
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with Apache 2.0 and clearly outlined the added dependency.

What are you changing?

Anything the reviewer should know when reviewing this PR?

If the there are associated PRs in other repositories, please link them here (i.e. open-amt-cloud-toolkit/repo#365 )

This is not a breaking change despite the variable names changing in the interface/implementation as typescript
doesn't enforce the parameter names.
@rsdmike rsdmike enabled auto-merge (rebase) September 14, 2023 17:55
@rsdmike rsdmike merged commit ce3c9da into main Sep 14, 2023
9 checks passed
@rsdmike rsdmike deleted the dbInterface branch September 14, 2023 17:57
@github-actions
Copy link

🎉 This PR is included in version 2.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants