Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add local wifi config #170

Merged
merged 2 commits into from
Sep 6, 2023
Merged

feat: add local wifi config #170

merged 2 commits into from
Sep 6, 2023

Conversation

Walt-Intel
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 93.75% and project coverage change: +3.74% 🎉

Comparison is base (f926eeb) 77.85% compared to head (bbc1c13) 81.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
+ Coverage   77.85%   81.59%   +3.74%     
==========================================
  Files          23       24       +1     
  Lines        2687     3293     +606     
==========================================
+ Hits         2092     2687     +595     
- Misses        479      487       +8     
- Partials      116      119       +3     
Files Changed Coverage Δ
internal/flags/configure.go 88.15% <87.97%> (+38.15%) ⬆️
internal/local/utils.go 93.70% <93.70%> (ø)
internal/flags/flags.go 100.00% <100.00%> (ø)
internal/flags/maintenance.go 84.14% <100.00%> (+1.79%) ⬆️
internal/local/configure.go 100.00% <100.00%> (+16.14%) ⬆️
internal/local/lps.go 82.85% <100.00%> (+0.50%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

internal/flags/info.go Fixed Show fixed Hide fixed
@tim-shockley tim-shockley force-pushed the local-wifi-config branch 2 times, most recently from 1e04ff2 to 3620926 Compare September 5, 2023 16:00
@madhavilosetty-intel
Copy link
Contributor

We just need one config file, and one secrets file that are generic to all functionalities.

internal/local/info.go Outdated Show resolved Hide resolved
internal/local/info.go Outdated Show resolved Hide resolved
secrets.yaml Outdated Show resolved Hide resolved
@tim-shockley tim-shockley force-pushed the local-wifi-config branch 2 times, most recently from 7c07122 to a08659d Compare September 5, 2023 22:24
@madhavilosetty-intel madhavilosetty-intel merged commit 06b67ec into main Sep 6, 2023
13 checks passed
@madhavilosetty-intel madhavilosetty-intel deleted the local-wifi-config branch September 6, 2023 02:56
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

🎉 This PR is included in version 2.14.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants