Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of additive coagulation example including comparison against PySDM #376

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Addition of additive coagulation example including comparison against PySDM #376

wants to merge 8 commits into from

Conversation

emmacware
Copy link
Collaborator

No description provided.

@emmacware emmacware mentioned this pull request Oct 15, 2024
Closed
@slayoo
Copy link
Member

slayoo commented Oct 24, 2024

  • include Julia Droplets.jl in the notebook
  • make the setup common also with the Julia code by using a dictionary of settings and writing it to a JSON file (as in the Trixi example in PyMPDATA)
  • switch settings and the plot construction to match Shima's box-model plot
  • add asserts wrt analytical solution
  • try if all works on Colab, mybinder and ARM JupyterHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emmacware @slayoo @jcurtis2