Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 chore: update part of the work api ReadOnly comment to clarify it's still possible to use status feedback #338

Merged
merged 1 commit into from
Jun 27, 2024
Merged

📖 chore: update part of the work api ReadOnly comment to clarify it's still possible to use status feedback #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion addon/v1alpha1/0000_03_addon.open-cluster-management.io_addontemplates.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,8 @@ spec:
ServerSideApply type means to update resource using server side apply with work-controller as the field manager.
If there is conflict, the related Applied condition of manifest will be in the status of False with the
reason of ApplyConflict.
ReadOnly type means the agent will only check the existence of the resource based on its metadata.
ReadOnly type means the agent will only check the existence of the resource based on its metadata,
statusFeedBackRules can still be used to get feedbackResults.
enum:
- Update
- CreateOnly
Expand Down
3 changes: 2 additions & 1 deletion work/v1/0000_00_work.open-cluster-management.io_manifestworks.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,8 @@ spec:
ServerSideApply type means to update resource using server side apply with work-controller as the field manager.
If there is conflict, the related Applied condition of manifest will be in the status of False with the
reason of ApplyConflict.
ReadOnly type means the agent will only check the existence of the resource based on its metadata.
ReadOnly type means the agent will only check the existence of the resource based on its metadata,
statusFeedBackRules can still be used to get feedbackResults.
enum:
- Update
- CreateOnly
Expand Down
3 changes: 2 additions & 1 deletion work/v1/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,8 @@ type UpdateStrategy struct {
// ServerSideApply type means to update resource using server side apply with work-controller as the field manager.
// If there is conflict, the related Applied condition of manifest will be in the status of False with the
// reason of ApplyConflict.
// ReadOnly type means the agent will only check the existence of the resource based on its metadata.
// ReadOnly type means the agent will only check the existence of the resource based on its metadata,
// statusFeedBackRules can still be used to get feedbackResults.
// +kubebuilder:default=Update
// +kubebuilder:validation:Enum=Update;CreateOnly;ServerSideApply;ReadOnly
// +kubebuilder:validation:Required
Expand Down
2 changes: 1 addition & 1 deletion work/v1/zz_generated.swagger_doc_generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion work/v1alpha1/0000_00_work.open-cluster-management.io_manifestworkreplicasets.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,8 @@ spec:
ServerSideApply type means to update resource using server side apply with work-controller as the field manager.
If there is conflict, the related Applied condition of manifest will be in the status of False with the
reason of ApplyConflict.
ReadOnly type means the agent will only check the existence of the resource based on its metadata.
ReadOnly type means the agent will only check the existence of the resource based on its metadata,
statusFeedBackRules can still be used to get feedbackResults.
enum:
- Update
- CreateOnly
Expand Down
Loading