✨ Add managed cluster arn for the klusterlet api #341
Conversation
suvaanshkumar
force-pushed
the
Klusterlet-Api-Change_Request
branch
from
dea25b8 to
e419c2d
Compare
There was a problem hiding this comment.
https://github.com/open-cluster-management-io/api/blob/main/docs/development.md
You need to follow some steps to autogen some additional changes.
suvaanshkumar
force-pushed
the
Klusterlet-Api-Change_Request
branch
from
e419c2d to
08d8638
Compare
| @@ -193,7 +193,8 @@ type AwsIrsa struct { | |||
| // The arn of the hub cluster (ie: an EKS cluster). This will be required to pass information to hub, which hub will use to create IAM identities for this klusterlet. | |||
| // Example - arn:eks:us-west-2:12345678910:cluster/hub-cluster1. | |||
| // +required | |||
| HubClusterArn string `json:"hubClusterArn"` | |||
| HubClusterArn string `json:"hubClusterArn"` | |||
| ManagedClusterArn string `json:"managedClusterArn"` | |||
There was a problem hiding this comment.
Could you please add a comment to describe what this field is for?
There was a problem hiding this comment.
if this is the required field, you would want a validation for minLength to be 1? Same for HubClusterArn
suvaanshkumar
force-pushed
the
Klusterlet-Api-Change_Request
branch
from
08d8638 to
cdcdc9b
Compare
|
/assign @qiujian16 |
Signed-off-by: Suvaansh <[email protected]>
jaswalkiranavtar
force-pushed
the
Klusterlet-Api-Change_Request
branch
from
c1636ec to
256710f
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikeshng, qiujian16, suvaanshkumar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit e49c54a
into
open-cluster-management-io:main
Summary
This change is needed to generate md5 hash in klusterlet_controller
Related issue(s)
Fixes #