Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Updated clustermanager API spec and generated files for spec change. #355

Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,28 @@ spec:
- feature
type: object
type: array
registrationDrivers:
description: |-
RegistrationDrivers represent the list of hub registration drivers that contain information used by hub to initialize the hub cluster
A RegistrationDriverHub contains details of authentication type and the hub cluster ARN
items:
properties:
authType:
default: csr
description: Type of the authentication used by hub to initialize
the Hub cluster. Possible values are csr and awsirsa.
enum:
- csr
- awsirsa
type: string
hubClusterArn:
description: This represents the hub cluster ARN
type: string
type: object
type: array
x-kubernetes-list-map-keys:
- authType
x-kubernetes-list-type: map
type: object
registrationImagePullSpec:
default: quay.io/open-cluster-management/registration
Expand Down
20 changes: 20 additions & 0 deletions operator/v1/types_clustermanager.go
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,26 @@ type RegistrationHubConfiguration struct {
// he can set featuregate/Foo=false before upgrading. Let's say the cluster-admin wants featuregate/Foo=false.
// +optional
FeatureGates []FeatureGate `json:"featureGates,omitempty"`

// RegistrationDrivers represent the list of hub registration drivers that contain information used by hub to initialize the hub cluster
// A RegistrationDriverHub contains details of authentication type and the hub cluster ARN
// +optional
// +listType=map
// +listMapKey=authType
RegistrationDrivers []RegistrationDriverHub `json:"registrationDrivers,omitempty"`
}

type RegistrationDriverHub struct {

// Type of the authentication used by hub to initialize the Hub cluster. Possible values are csr and awsirsa.
// +required
// +kubebuilder:default:=csr
// +kubebuilder:validation:Enum=csr;awsirsa
AuthType string `json:"authType,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment, we should add

// +listType=map
// +listMapKey=authType
here, so we will not set duplicate type


// This represents the hub cluster ARN
// +optional
HubClusterArn string `json:"hubClusterArn,omitempty"`
}

type WorkConfiguration struct {
Expand Down
21 changes: 21 additions & 0 deletions operator/v1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 12 additions & 2 deletions operator/v1/zz_generated.swagger_doc_generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading