-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: upgrade clusterset clustersetbinding to v1beta2 #81
fix: upgrade clusterset clustersetbinding to v1beta2 #81
Conversation
Signed-off-by: haoqing0110 <[email protected]>
@haoqing0110 it seems that you only changed the API version without modifying other fields, is that the case? |
Hello @ilan-pinto it looks like the *.json files I'm updating only have a spec.clusterSet field defined, this part does not change in v1beta2. I have tested the code with vscode debug, not sure if more testing needed? |
@haoqing0110 try to apply it on a local cluster to confirm |
@ilan-pinto thanks for providing some comments, plz see my testing result in the above, the v1beta2 works. |
hello @ilan-pinto , could you help to tag this PR? |
@haoqing0110 Sorry for the delay; I will take a look at this. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haoqing0110, TomerFi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@haoqing0110 Thank you very much! I apologize for the delays. |
cf2653c
into
open-cluster-management-io:main
Releasing is currently blocked, fixed in #82. |
Finally, early-access version released. |
Sorry for the delay, we had an issue with our api key and I missed a message with our new one. |
Refer to open-cluster-management-io/api#266, the ClusterSet ClusterSetBinding API version v1beta1 has been removed, need to upgrade the API to v1beta2.