-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]:sparkles: config agent leader election by klusterletconfig #719
base: main
Are you sure you want to change the base?
[WIP]:sparkles: config agent leader election by klusterletconfig #719
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: haoqing0110 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f72dbe6
to
3d47191
Compare
/hold more testing cases to add. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #719 +/- ##
==========================================
+ Coverage 63.48% 63.57% +0.09%
==========================================
Files 185 185
Lines 17827 17883 +56
==========================================
+ Hits 11317 11369 +52
- Misses 5578 5581 +3
- Partials 932 933 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cb03666
to
1d29ae0
Compare
Signed-off-by: Qing Hao <[email protected]>
Signed-off-by: Qing Hao <[email protected]>
bebdbe4
to
247308d
Compare
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Summary
Previously submitted PR #695 to enable leader election of klusterlet-agent on single node managed cluster. It breaks some user e2e testing cases as they are using SNO for testing #708, enabling the SNO leader election might cause the agent to wait as bad as 137s to start working.
Create this PR to make the agent leader election time configurable by
klusterletconfig
, so that user can reduce the time in testing.Related issue(s)
#695
#708