Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]:sparkles: config agent leader election by klusterletconfig #719

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

haoqing0110
Copy link
Member

@haoqing0110 haoqing0110 commented Nov 22, 2024

Summary

Previously submitted PR #695 to enable leader election of klusterlet-agent on single node managed cluster. It breaks some user e2e testing cases as they are using SNO for testing #708, enabling the SNO leader election might cause the agent to wait as bad as 137s to start working.

Create this PR to make the agent leader election time configurable by klusterletconfig, so that user can reduce the time in testing.

Related issue(s)

#695
#708

Copy link
Contributor

openshift-ci bot commented Nov 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: haoqing0110
Once this PR has been reviewed and has the lgtm label, please assign jnpacker for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@haoqing0110
Copy link
Member Author

/hold more testing cases to add.

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 12 lines in your changes missing coverage. Please review.

Project coverage is 63.57%. Comparing base (93db6de) to head (247308d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...lers/klusterletcontroller/klusterlet_controller.go 92.18% 4 Missing and 1 partial ⚠️
pkg/singleton/spoke/agent.go 0.00% 4 Missing ⚠️
pkg/registration/spoke/spokeagent.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #719      +/-   ##
==========================================
+ Coverage   63.48%   63.57%   +0.09%     
==========================================
  Files         185      185              
  Lines       17827    17883      +56     
==========================================
+ Hits        11317    11369      +52     
- Misses       5578     5581       +3     
- Partials      932      933       +1     
Flag Coverage Δ
unit 63.57% <83.33%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants