Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Should use metadata name queue key func for addon informer #722

Conversation

qiujian16
Copy link
Member

@qiujian16 qiujian16 commented Nov 25, 2024

Summary

This is because in #654 we change the way to get key, but the missing part is the queuekey func for addon informers.

Related issue(s)

Fixes #

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.41%. Comparing base (7a190f1) to head (e60ae0a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...kg/addon/controllers/addonmanagement/controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #722   +/-   ##
=======================================
  Coverage   63.41%   63.41%           
=======================================
  Files         185      185           
  Lines       17802    17802           
=======================================
  Hits        11290    11290           
- Misses       5580     5581    +1     
+ Partials      932      931    -1     
Flag Coverage Δ
unit 63.41% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@qiujian16
Copy link
Member Author

/assign @zhujian7

Copy link
Contributor

openshift-ci bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhujian7
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 25, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 627a16d into open-cluster-management-io:main Nov 25, 2024
16 checks passed
@qiujian16 qiujian16 deleted the fix-addonmanagement-queuekey branch November 25, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants