Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Move index func from addon framework to ocm #728

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

zhujian7
Copy link
Member

Summary

Related issue(s)

Fixes #

@zhujian7
Copy link
Member Author

/cc @qiujian16 @haoqing0110

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 60 lines in your changes missing coverage. Please review.

Project coverage is 63.32%. Comparing base (93db6de) to head (a75c1f0).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/addon/index/index.go 9.67% 53 Missing and 3 partials ⚠️
...addon/controllers/addonconfiguration/controller.go 33.33% 2 Missing ⚠️
...kg/addon/controllers/addonmanagement/controller.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #728      +/-   ##
==========================================
- Coverage   63.48%   63.32%   -0.16%     
==========================================
  Files         185      186       +1     
  Lines       17827    17900      +73     
==========================================
+ Hits        11317    11335      +18     
- Misses       5578     5629      +51     
- Partials      932      936       +4     
Flag Coverage Δ
unit 63.32% <16.66%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -27,6 +26,7 @@ import (
clusterv1alpha1 "open-cluster-management.io/api/cluster/v1alpha1"
clusterv1beta1 "open-cluster-management.io/api/cluster/v1beta1"

amindex "open-cluster-management.io/ocm/pkg/addon/index"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this name a bit weird, how about addonindex or indexaddon?

@qiujian16
Copy link
Member

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Dec 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 2, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 6e367a2 into open-cluster-management-io:main Dec 2, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants