-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Move index func from addon framework to ocm #728
🌱 Move index func from addon framework to ocm #728
Conversation
87c43ba
to
f6084ef
Compare
Signed-off-by: zhujian <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #728 +/- ##
==========================================
- Coverage 63.48% 63.32% -0.16%
==========================================
Files 185 186 +1
Lines 17827 17900 +73
==========================================
+ Hits 11317 11335 +18
- Misses 5578 5629 +51
- Partials 932 936 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -27,6 +26,7 @@ import ( | |||
clusterv1alpha1 "open-cluster-management.io/api/cluster/v1alpha1" | |||
clusterv1beta1 "open-cluster-management.io/api/cluster/v1beta1" | |||
|
|||
amindex "open-cluster-management.io/ocm/pkg/addon/index" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this name a bit weird, how about addonindex or indexaddon?
Signed-off-by: zhujian <[email protected]>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6e367a2
into
open-cluster-management-io:main
Summary
Related issue(s)
Fixes #