Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [release-0.15] Only bind the agent role for the addon group #734

Conversation

zhujian7
Copy link
Member

@zhujian7 zhujian7 commented Dec 3, 2024

  • Only bind the agent role for the addon group

  • Update addon rolebinding

  • Start an addon informor for each addon


Summary

Related issue(s)

Fixes #

…r-management-io#157)

* Only bind the agent role for the addon group

Signed-off-by: zhujian <[email protected]>

* Update addon rolebinding

Signed-off-by: zhujian <[email protected]>

* Start an addon informor for each addon

Signed-off-by: zhujian <[email protected]>

---------

Signed-off-by: zhujian <[email protected]>
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 84.90566% with 8 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-0.15@07092e0). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/addon/controllers/addontemplate/controller.go 71.42% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release-0.15     #734   +/-   ##
===============================================
  Coverage                ?   62.97%           
===============================================
  Files                   ?      182           
  Lines                   ?    17633           
  Branches                ?        0           
===============================================
  Hits                    ?    11104           
  Misses                  ?     5615           
  Partials                ?      914           
Flag Coverage Δ
unit 62.97% <84.90%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhujian7
Copy link
Member Author

zhujian7 commented Dec 4, 2024

/cc @qiujian16

@openshift-ci openshift-ci bot requested a review from qiujian16 December 4, 2024 01:54
@qiujian16
Copy link
Member

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Dec 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 649a05d into open-cluster-management-io:release-0.15 Dec 4, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants