Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Allow Custom Signer signingCA to Specify Namespace in AddOnTemplate #747

Merged

Conversation

zhujian7
Copy link
Member

@zhujian7 zhujian7 commented Dec 6, 2024

Summary

Related issue(s)

#688

Fixes #

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.58%. Comparing base (1ef5904) to head (d1d526c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/addon/templateagent/registration.go 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #747      +/-   ##
==========================================
+ Coverage   63.43%   63.58%   +0.15%     
==========================================
  Files         187      187              
  Lines       17985    17989       +4     
==========================================
+ Hits        11409    11439      +30     
+ Misses       5637     5601      -36     
- Partials      939      949      +10     
Flag Coverage Δ
unit 63.58% <71.42%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhujian7 zhujian7 force-pushed the sign-ca-namespace branch 3 times, most recently from efba42f to 73a905d Compare December 9, 2024 09:31
@zhujian7
Copy link
Member Author

/cc @qiujian16

@openshift-ci openshift-ci bot requested a review from qiujian16 December 10, 2024 06:29
@zhujian7
Copy link
Member Author

/cc @mikeshng

@openshift-ci openshift-ci bot requested a review from mikeshng December 10, 2024 06:29
@qiujian16
Copy link
Member

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ddc5024 into open-cluster-management-io:main Dec 10, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants