Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syntax highlighting in clusterclaim #377

Conversation

ydFu
Copy link
Member

@ydFu ydFu commented Aug 17, 2023

While reviewing the aforementioned article, I discerned a deficiency in Syntax highlighting implementation.
Syntax highlighting entails the alteration of color and style attributes of source code, thereby enhancing its readability. Consequently, I undertook a comprehensive revision of all YAML files within the ClusterClaim article, integrating Syntax highlighting.
This augmentation was executed with the primary objective of rendering the article content more accessible and comprehensible to its readership.

@mikeshng
Copy link
Member

/approve

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng, ydFu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit afb498e into open-cluster-management-io:main Aug 17, 2023
2 checks passed
@ydFu ydFu deleted the update-clusterclaim branch August 17, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants