Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated due to a clusteradm update.[1/2] #379

Merged
merged 1 commit into from
Aug 26, 2023
Merged

Updated due to a clusteradm update.[1/2] #379

merged 1 commit into from
Aug 26, 2023

Conversation

ydFu
Copy link
Member

@ydFu ydFu commented Aug 25, 2023 •
edited
Loading

  1. clusteradm is updated,correct spelling of output table fix: correct spelling of output table clusteradm#218 ,Consequently, the output values are being reconfigured.
  2. Adding syntax highlighting enhances readability for the readers.

@openshift-ci openshift-ci bot requested review from mikeshng and mprahl August 25, 2023 09:51
mikeshng
mikeshng approved these changes Aug 26, 2023
View reviewed changes
Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/lgtm

thanks!

@openshift-ci openshift-ci bot added the lgtm label Aug 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng, ydFu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9af728e into open-cluster-management-io:main Aug 26, 2023
2 checks passed
@ydFu ydFu deleted the update-extend-multicluster-scheduling-capabilities branch August 27, 2023 03:30
@ydFu ydFu changed the title Updated due to a clusteradm update. Updated due to a clusteradm update.[1/2] Aug 28, 2023
@ydFu ydFu mentioned this pull request Aug 31, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeshng mikeshng mikeshng approved these changes

@mprahl mprahl Awaiting requested review from mprahl

Assignees

@mikeshng mikeshng

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ydFu @mikeshng @openshift-merge-robot