Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated due to a clusteradm update.[2/2] #381

Conversation

ydFu
Copy link
Member

@ydFu ydFu commented Aug 28, 2023

  1. clusteradm is updated,correct spelling of output table fix: correct spelling of output table clusteradm#218 ,Consequently, the output values are being reconfigured.
  2. Adjusting proper indentation for improved formatting.
  3. Modify the project name to avoid the use of abbreviations and rewrite it in its formal full form. Argo CD

Copy link
Member

@dhaiducek dhaiducek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! I missed this in the previous PR, but would you sync these (and the previous) changes to content/zh/scenarios/distribute-workload-with-placement.md also?

@ydFu ydFu force-pushed the update-distribute-workload-with-placement branch from 11d8c3b to 2dbb488 Compare August 29, 2023 08:12
@ydFu
Copy link
Member Author

ydFu commented Aug 29, 2023

Thanks for the update! I missed this in the previous PR, but would you sync these (and the previous) changes to content/zh/scenarios/distribute-workload-with-placement.md also?

Thank you for your suggestion, I will also update the relevant content/zh/scenarios/distribute-workload-with-placement.md files together.

Copy link
Member

@dhaiducek dhaiducek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the update!

@openshift-ci openshift-ci bot added the lgtm label Aug 29, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, ydFu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2a151f4 into open-cluster-management-io:main Aug 29, 2023
2 checks passed
@ydFu ydFu deleted the update-distribute-workload-with-placement branch August 29, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants