Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update addon rollout api #396

Merged
merged 1 commit into from
Dec 14, 2023
Merged

update addon rollout api #396

merged 1 commit into from
Dec 14, 2023

Conversation

haoqing0110
Copy link
Member

No description provided.

@haoqing0110
update addon rollout api
b956a9c 
Signed-off-by: haoqing0110 <[email protected]>
@haoqing0110
Copy link
Member Author

/hold

@qiujian16
Copy link
Member

/assign @serngawy

@haoqing0110
Copy link
Member Author

haoqing0110 commented Nov 10, 2023 •
edited
Loading

Hold this PR, will add more content for new added RolloutConfig field.

@haoqing0110
Copy link
Member Author

/unhold

@haoqing0110
Copy link
Member Author

After testing, the addon needs extra code changes to support MinSuccessTime, ProgressDeadline and MaxFailures
open-cluster-management-io/ocm#332. So can merge this PR first, this PR only update some existing fileds examples.

@mikeshng
Copy link
Member

CC @dhaiducek @mprahl who are also familiar with rollouts

@openshift-ci openshift-ci bot added the lgtm label Dec 13, 2023
@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haoqing0110, qiujian16, serngawy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ed88430 into open-cluster-management-io:main Dec 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serngawy serngawy serngawy approved these changes

@mikeshng mikeshng Awaiting requested review from mikeshng

@qiujian16 qiujian16 Awaiting requested review from qiujian16

Assignees

@serngawy serngawy

@qiujian16 qiujian16

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@haoqing0110 @qiujian16 @mikeshng @serngawy