Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate workload with placement #399

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Migrate workload with placement #399

merged 2 commits into from
Nov 15, 2023

Conversation

haoqing0110
Copy link
Member

@haoqing0110 haoqing0110 commented Nov 14, 2023 •
edited
Loading

@haoqing0110
Copy link
Member Author

/assign @qiujian16 @mikeshng

@haoqing0110
Copy link
Member Author

Hello @mikeshng , in this scenario I use the ArgoCD pull model as an example, to show how we can migrate
the Applications among clusters by Placement taint & toleration. Could you help take a review from ArgoCD integration's view, to see if it makes sense, and any comments?

@qiujian16
Copy link
Member

@mikeshng would you like to take a look at this one?

@mikeshng
Copy link
Member

Ok. I will take a look today. Missed the email notification last time.

mikeshng
mikeshng reviewed Nov 15, 2023
View reviewed changes
Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haoqing0110 this is amazing work. Thank you!

Just minor fixes. Could you please make the same changes in the zh file? Thanks.

content/en/scenarios/migrate-workload-with-placement.md Outdated Show resolved Hide resolved
content/en/scenarios/migrate-workload-with-placement.md Outdated Show resolved Hide resolved
content/en/scenarios/migrate-workload-with-placement.md Outdated Show resolved Hide resolved
content/en/scenarios/migrate-workload-with-placement.md Outdated Show resolved Hide resolved
content/en/scenarios/migrate-workload-with-placement.md Outdated Show resolved Hide resolved
content/en/scenarios/migrate-workload-with-placement.md Outdated Show resolved Hide resolved
@haoqing0110
Copy link
Member Author

@mikeshng thanks for the review, have accepted all the comments and synced changes to zh/ folder.

mikeshng
mikeshng approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 15, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haoqing0110, mikeshng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 71b9649 into open-cluster-management-io:main Nov 15, 2023
3 checks passed
@haoqing0110 haoqing0110 deleted the br_placement-argo branch November 15, 2023 15:41
This was referenced Nov 15, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeshng mikeshng mikeshng approved these changes

@mprahl mprahl Awaiting requested review from mprahl

Assignees

@qiujian16 qiujian16

@mikeshng mikeshng

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haoqing0110 @qiujian16 @mikeshng