Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the website sidebar content #401

Merged

Conversation

haoqing0110
Copy link
Member

  1. Add "ManifestWorkReplicaSet" and "Multicluster Control Plane" to sidebar.
  2. Adjust the sidebar concepts sequence.

The output would be like:

Screenshot 2023-11-15 at 15 40 53

@haoqing0110
Copy link
Member Author

/assign @qiujian16

Copy link
Member

@dhaiducek dhaiducek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reordering looks good to me! I noticed some working updates needed in the docs (that I'm thinking would also need to be copied over to the en/ directory also since I'm assuming this was copied and pasted?).

content/zh/concepts/manifestworkreplicaset.md Outdated Show resolved Hide resolved
content/zh/concepts/manifestworkreplicaset.md Outdated Show resolved Hide resolved
content/zh/concepts/manifestworkreplicaset.md Outdated Show resolved Hide resolved
content/zh/concepts/manifestworkreplicaset.md Outdated Show resolved Hide resolved
content/zh/concepts/manifestworkreplicaset.md Outdated Show resolved Hide resolved
content/zh/concepts/multicluster-controlplane.md Outdated Show resolved Hide resolved
content/zh/concepts/multicluster-controlplane.md Outdated Show resolved Hide resolved
content/zh/concepts/multicluster-controlplane.md Outdated Show resolved Hide resolved
content/zh/concepts/multicluster-controlplane.md Outdated Show resolved Hide resolved
content/zh/concepts/multicluster-controlplane.md Outdated Show resolved Hide resolved
Update content/zh/concepts/multicluster-controlplane.md

Co-authored-by: Dale Haiducek <[email protected]>
Signed-off-by: haoqing0110 <[email protected]>
@haoqing0110
Copy link
Member Author

@dhaiducek thanks for the detailed review! yes, zh/ folder is copied from en/ folder, have synced all of your comments to en/ folder.

Copy link
Member

@dhaiducek dhaiducek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, @haoqing0110!

@openshift-ci openshift-ci bot added the lgtm label Nov 15, 2023
Copy link
Contributor

openshift-ci bot commented Nov 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, haoqing0110

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9d323e3 into open-cluster-management-io:main Nov 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants