Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release announcement for 0.13.0 #409

Merged
merged 4 commits into from
Mar 15, 2024
Merged

Release announcement for 0.13.0 #409

merged 4 commits into from
Mar 15, 2024

Conversation

qiujian16
Copy link
Member

No description provided.

@openshift-ci openshift-ci bot added the approved label Mar 6, 2024
@zhujian7
Copy link
Member

zhujian7 commented Mar 7, 2024

I think we should mention that when upgrading addon-framework to 0.9.0, patch clustermanagementaddon permission should be added.

mikeshng
mikeshng reviewed Mar 11, 2024
View reviewed changes
Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to highlight an app addon feature. The rest LGTM.

content/en/community/releases.md Show resolved Hide resolved
@qiujian16
Add RBAC update note.
4aa7312 
Signed-off-by: Jian Qiu <[email protected]>
dhaiducek
dhaiducek suggested changes Mar 12, 2024
View reviewed changes
Copy link
Member

@dhaiducek dhaiducek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for my belated review. I've added a couple bullets for Policy as well as suggested some other spelling/wording edits.

content/en/community/releases.md Outdated Show resolved Hide resolved
content/en/community/releases.md Outdated Show resolved Hide resolved
content/en/community/releases.md Outdated Show resolved Hide resolved
content/en/community/releases.md Outdated Show resolved Hide resolved
content/en/community/releases.md Show resolved Hide resolved
@qiujian16
Resolve comments
97fa649 
Signed-off-by: Jian Qiu <[email protected]>
dhaiducek
dhaiducek approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@dhaiducek dhaiducek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold LGTM! Thanks--holding in case there are other reviews needed.

mikeshng
mikeshng approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, mikeshng, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dhaiducek,mikeshng,qiujian16]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mikeshng
Copy link
Member

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit e54a17c into open-cluster-management-io:main Mar 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhujian7 zhujian7 zhujian7 left review comments

@mprahl mprahl mprahl left review comments

@mikeshng mikeshng mikeshng approved these changes

@dhaiducek dhaiducek dhaiducek approved these changes

Assignees

@dhaiducek dhaiducek

@mikeshng mikeshng

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qiujian16 @zhujian7 @mikeshng @mprahl @dhaiducek