Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes for addon template permission setting #424

Conversation

zhujian7
Copy link
Member

@zhujian7 zhujian7 commented Jul 3, 2024

No description provided.

addon-agent. For example: users can create a (cluster)rolebinding to grant the permission to the
addon-manager (service account `open-cluster-management-hub/addon-manager-controller-sa`) to address the
permission issue on the hub cluster side.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could here use the template role cm-admin cm-reader as an example, to add a clusterrolebinding example after step3.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The beginner usually copies the example yaml we provide and do some modification.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

Copy link

@z1ens z1ens Jul 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 1126 permission-setting-for-work-agent

Here the link seems like not valid when clicking it on the OCM website.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhujian7 zhujian7 force-pushed the addon-template-rolebinding branch from 9654381 to d529f30 Compare July 4, 2024 07:56
@zhujian7 zhujian7 marked this pull request as ready for review July 4, 2024 07:57
@openshift-ci openshift-ci bot requested review from dhaiducek and mikeshng July 4, 2024 07:57
@haoqing0110
Copy link
Member

/lgtm

@zhujian7
Copy link
Member Author

zhujian7 commented Jul 4, 2024

/cc @qiujian16

@openshift-ci openshift-ci bot requested a review from qiujian16 July 4, 2024 09:24
@qiujian16
Copy link
Member

/approve

Copy link
Contributor

openshift-ci bot commented Jul 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jul 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 9e09bcf into open-cluster-management-io:main Jul 4, 2024
3 checks passed
@zhujian7 zhujian7 mentioned this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants