Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hugo wrapper. #427

Conversation

xuezhaojun
Copy link
Member

@xuezhaojun xuezhaojun commented Aug 15, 2024

The hugo-wrapper has been inactive for years.

Recently, when I use Apple Silicon laptop to run make server, it returns error:

(sleep 2; /usr/bin/open http://localhost:1313) &
./hugo server
Error: Unknown OS type or architecture

So change to let developer install hugo by themselves, and using a active github action(1.5k starts and last update is 2 month ago) to setup hugo in github workflow

Signed-off-by: xuezhaojun <[email protected]>
@xuezhaojun
Copy link
Member Author

/assign @qiujian16

@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 15, 2024
Copy link
Contributor

openshift-ci bot commented Aug 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7e484de into open-cluster-management-io:main Aug 15, 2024
3 checks passed
@xuezhaojun xuezhaojun deleted the remove-hugo-wrapper branch August 15, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants