-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor using docsy. #429
Refactor using docsy. #429
Conversation
5f5ff9e
to
4c183fc
Compare
/assign @mikeshng |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xuezhaojun This is amazing! Nice!!
Could you please check and adjust the build GitHub action? It's been building for 4 hrs now.
@mikeshng Do you have permission to kill it? Looks like it's going to run indefinitely:
|
4c183fc
to
6a7e4a1
Compare
@mikeshng @dhaiducek Thanks for reminding, the github action was updated and passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What a massive effort, @xuezhaojun! Thanks for all your work here!
I've left a few minor questions/comments/tweaks.
I'm also wondering: Can the background be set to stay in one place on the home page and all the elements scroll up over top of it? I think that'd be a slick effect if it's feasible.
content/en/blog/ocm-configuring-your-kubernetes-fleet-with-the-policy-addon/index.md
Outdated
Show resolved
Hide resolved
content/en/docs/getting-started/integration/policy-controllers/gatekeeper.md
Outdated
Show resolved
Hide resolved
content/en/docs/getting-started/integration/policy-controllers/configuration-policy.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xuezhaojun this is great. Could you also post this PR and some screenshots in our Slack channel for awareness and potentially some feedback. I just uploaded your presentation to YouTube, maybe you can link that in your Slack post as well. Thanks.
Signed-off-by: xuezhaojun <[email protected]>
9752a5f
to
c6cd625
Compare
Hi @dhaiducek @mikeshng thanks for your review and helpful comments, I've updated the PR and posted in our Slack channel: https://kubernetes.slack.com/archives/C01GE7YSUUF/p1726696168876759. |
👍 That sounds like a cool feature to add. Currently, I'm purely using the shortcode Docsy recommends in their example, but we can definitely implement the landing page by ourselves. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikeshng, xuezhaojun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm If there are any additional feedback and comments we can fix them in another PR. |
3f36d75
into
open-cluster-management-io:main
The slides: https://docs.google.com/presentation/d/1iTY-EfcHLXZye9C6af7u9rUyOVDrkAUhdC869SHvJc4/edit#slide=id.g28966f3b7e0_0_61
Where you can view the new look: https://ocm-preview.netlify.app/
Discussion video: https://www.youtube.com/watch?v=kl50rlcHUxU&ab_channel=OpenClusterManagement
PS:
zh
part is not included, after review the content, I found only less than 5% part of the whole content is written in zh, that means at this point of time we better focus on providing more easy-to-ready, A classen
doc rather multiple languages.zh
blogs anden
blogs are merged.supported by
currently not visible since we have new adopters, will refresh this section later.TODO: