feat(condo): DOMA-8629 added property meters importer #5589
Conversation
abshnko
commented
Dec 9, 2024
•
abshnko
commented
- cc (will merge cc before merging this PR)
- add excel template for property meters
|
| interface IExtraProps { | ||
| isPropertyMeters?: boolean | ||
| } |
There was a problem hiding this comment.
This file is used in all imports (except meters). Maybe its better to add extra field explicitly in meters domain?
Another option is add extraProps field using generic interface: define interface of extraProps within particular domain.
export interface IImportWrapperProps<TExtraProps = unknown> {
...
extraProps?: TExtraProps,
}| } = props | ||
|
|
||
| const intl = useIntl() | ||
| const domain = 'meter' | ||
| const domain = extraProps?.isPropertyMeters ? 'propertyMeter' : 'meter' |
There was a problem hiding this comment.
domain was a constant, but now it is a variable. Please add it to the dependency list of hooks below.
| @@ -64,6 +65,7 @@ const MetersImportWrapper: React.FC<IMetersImportWrapperProps> = (props) => { | |||
| file: fileRef, | |||
| userId: user?.id || null, | |||
| organizationId: organization?.id || null, | |||
| isPropertyMeters: extraProps?.isPropertyMeters ? extraProps.isPropertyMeters : false, | |||
There was a problem hiding this comment.
It's simpler a bit.
| isPropertyMeters: extraProps?.isPropertyMeters ? extraProps.isPropertyMeters : false, | |
| isPropertyMeters: Boolean(extraProps?.isPropertyMeters), |
| @@ -49,7 +50,7 @@ const { EXCEL } = require('@condo/domains/common/constants/export') | |||
| const { LOCALE_EN } = require('@condo/domains/user/constants/common') | |||
|
|
|||
|
|
|||
| async function createTestMeterResource (client, extraAttrs = {}) { | |||
There was a problem hiding this comment.
Please tune your IDE settings.
In most cases, we use space when defining functions and not use space when calling functions.
There was a problem hiding this comment.
you're right, i confused the styling for some reason
| @@ -524,5 +546,6 @@ module.exports = { | |||
| createTestReadingData, registerMetersReadingsByTestClient, | |||
| MeterReadingsImportTask, createTestMeterReadingsImportTask, updateTestMeterReadingsImportTask, | |||
| MeterReadingExportTask, createTestMeterReadingExportTask, updateTestMeterReadingExportTask, | |||
| /* AUTOGENERATE MARKER <EXPORTS> */ | |||
| registerPropertyMetersReadingsByTestClient, | |||
| /* AUTOGENERATE MARKER <EXPORTS> */ | |||
There was a problem hiding this comment.
| /* AUTOGENERATE MARKER <EXPORTS> */ | |
| /* AUTOGENERATE MARKER <EXPORTS> */ |
abshnko
force-pushed
the
feat/condo/DOMA-8629/add-property-readings-importer
branch
from
f5d5126 to
8a7b7da
Compare
…ion for possible new integrations that might pass house globalId
…rom addresses (when no unitName passed)
…mportTask and canExecuteRegisterPropertyMetersReadings field to B2BAppAccessRightSet
abshnko
force-pushed
the
feat/condo/DOMA-8629/add-property-readings-importer
branch
from
6bff482 to
84ac334
Compare
|
