Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix: fix new receipts push task fallings #5715

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

hotfix: fix new receipts push task fallings #5715

wants to merge 2 commits into from

Conversation

vovaaxeapolla
Copy link
Contributor

No description provided.

@vovaaxeapolla vovaaxeapolla force-pushed the hotfix/condo/new-receipts-tasks-falling branch from c22a72b to c12ad4b Compare January 24, 2025 12:20
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

AleX83Xpert
AleX83Xpert approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@AleX83Xpert AleX83Xpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I see variable named organizationId I not ready to see an object inside :)

SavelevMatthew
SavelevMatthew requested changes Jan 24, 2025
View reviewed changes
Copy link
Member

@SavelevMatthew SavelevMatthew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @AleX83Xpert said, organizationId must contain id, not filter. Clear variable naming is the key to code sustainability...

And also, why is it taken from resident? Aren't we notifying about service providers as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SavelevMatthew SavelevMatthew SavelevMatthew requested changes

@AleX83Xpert AleX83Xpert AleX83Xpert approved these changes

@YEgorLu YEgorLu YEgorLu approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vovaaxeapolla @AleX83Xpert @SavelevMatthew @YEgorLu