Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: circuvent meilisearch bug with empty objects #695

Conversation

rpenido
Copy link
Member

@rpenido rpenido commented Oct 8, 2024

No description provided.

@navinkarkera navinkarkera force-pushed the navin/component-collection-api branch from 3e889a9 to cd9eec9 Compare October 10, 2024 06:20
@navinkarkera navinkarkera force-pushed the navin/component-collection-api branch from 1debf71 to baa10fc Compare October 10, 2024 09:39
Using `get_collection_components` does not work in case of post_remove
as the component is already removed from collection and we don't really
need additional filtering as we already have pk_set from the signal.
@rpenido rpenido force-pushed the rpenido/navin/component-collection-api-fix-meilisearch branch 2 times, most recently from ccb2c54 to 6543313 Compare October 10, 2024 15:51
@rpenido rpenido force-pushed the rpenido/navin/component-collection-api-fix-meilisearch branch from 6543313 to 758334f Compare October 10, 2024 19:26
@navinkarkera navinkarkera force-pushed the navin/component-collection-api branch 2 times, most recently from 4409ddc to bdee940 Compare October 11, 2024 05:49
@navinkarkera navinkarkera merged commit 793e7bc into navin/component-collection-api Oct 11, 2024
28 of 41 checks passed
@navinkarkera navinkarkera deleted the rpenido/navin/component-collection-api-fix-meilisearch branch October 11, 2024 05:52
navinkarkera added a commit that referenced this pull request Oct 12, 2024
…ction-api-fix-meilisearch

fix: circuvent meilisearch bug with empty objects
navinkarkera added a commit that referenced this pull request Oct 15, 2024
…ction-api-fix-meilisearch

fix: circuvent meilisearch bug with empty objects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants