Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds Library Content button to Studio Unit page #699

Conversation

pomegranited
Copy link
Member

@pomegranited pomegranited commented Oct 16, 2024

Clicking the iframes the Authoring MFE's Library Content Picker.

image

image

Testing instructions

  1. Disable these waffle flags to access the legacy Studio Unit page:
    • contentstore.new_studio_mfe.use_new_course_outline_page
    • contentstore.new_studio_mfe.use_new_unit_page
  2. Create a course and edit a Unit there.
  3. Click the new Library Content to open the library content picker, and select a block to copy into the course.
  4. Refresh the Unit page to see the newly added block (see concerns below).

Author Concerns and Issues

With the Content Picker:

  1. iframe event doesn't tell us what block ID was added to the Unit, only that we should close the picker. So we have to refresh the whole Unit page to see the added component.
  2. Needs some style updates to fit within our iframe.

With this code:

  1. Need to handle ESC and/or clicking outside the modal to cancel the operation.
  2. Should add a placeholder element (like normal XBlocks do), so when the CP returns the new course block ID, we can just refresh that XBlock location.

iframes the Authoring MFE's Library Content Picker
@bradenmacdonald
Copy link
Member

Closing in favor of openedx#35670

@rpenido rpenido deleted the jill/rpenido/fal-3876-add-library-content-to-a-course branch October 25, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants