fix: Update discussion provider featues

Updates "Partial Support" to "Basic Support" Changes "edX" to Full Support. Uses data from the api for support level. Refactor some app messages. https://openedx.atlassian.net/browse/TNL-8546
open-craft · Jul 30, 2021 · 6b7f77f · 6b7f77f
1 parent 28107fc
commit 6b7f77f
Show file tree

Hide file tree

Showing 8 changed files with 25 additions and 28 deletions.
diff --git a/src/pages-and-resources/discussions/app-list/AppCard.jsx b/src/pages-and-resources/discussions/app-list/AppCard.jsx
@@ -14,8 +14,7 @@ function AppCard({
 }) {
   const supportText = app.hasFullSupport
     ? intl.formatMessage(messages.appFullSupport)
-    : intl.formatMessage(messages.appPartialSupport);
-
+    : intl.formatMessage(messages.appBasicSupport);
   return (
     <Card
       key={app.id}

diff --git a/src/pages-and-resources/discussions/app-list/AppCard.test.jsx b/src/pages-and-resources/discussions/app-list/AppCard.test.jsx
@@ -62,10 +62,10 @@ describe('AppCard', () => {
   });
 
   test('partial support subtitle shown when hasFullSupport is false', () => {
-    const appWithPartialSupport = { ...app, hasFullSupport: false };
-    const subtitle = messages.appPartialSupport.defaultMessage;
+    const appWithBasicSupport = { ...app, hasFullSupport: false };
+    const subtitle = messages.appBasicSupport.defaultMessage;
 
-    const { container } = wrapper(appWithPartialSupport);
+    const { container } = wrapper(appWithBasicSupport);
 
     expect(container.querySelector('.card-subtitle')).toHaveTextContent(subtitle);
   });

diff --git a/src/pages-and-resources/discussions/app-list/FeatureList.test.jsx b/src/pages-and-resources/discussions/app-list/FeatureList.test.jsx
@@ -15,7 +15,7 @@ describe('FeaturesList', () => {
     id: 'legacy',
   };
   const features = [
-    { id: 'lti' },
+    { id: 'lti-basic-configuration' },
     { id: 'wcag-2.1' },
     { id: 'discussion-page' },
     { id: 'embedded-course-sections' },

diff --git a/src/pages-and-resources/discussions/app-list/FeaturesTable.test.jsx b/src/pages-and-resources/discussions/app-list/FeaturesTable.test.jsx
@@ -19,13 +19,13 @@ describe('FeaturesTable', () => {
       },
       {
         externalLinks: {},
-        featureIds: ['discussion-page', 'lti'],
+        featureIds: ['discussion-page', 'lti-basic-configuration'],
         hasFullSupport: false,
         id: 'piazza',
       }];
 
     features = [
-      { id: 'lti' },
+      { id: 'lti-basic-configuration' },
       { id: 'wcag-2.1' },
       { id: 'discussion-page' },
       { id: 'embedded-course-sections' },

diff --git a/src/pages-and-resources/discussions/app-list/messages.js b/src/pages-and-resources/discussions/app-list/messages.js
@@ -34,9 +34,9 @@ const messages = defineMessages({
     defaultMessage: 'Full support',
     description: 'A label indicating that an app supports the full set of possible features for a discussions app.',
   },
-  appPartialSupport: {
-    id: 'authoring.discussions.appPartialSupport',
-    defaultMessage: 'Partial support',
+  appBasicSupport: {
+    id: 'authoring.discussions.appBasicSupport',
+    defaultMessage: 'Basic support',
     description: 'A label indicating that an app only supports a subset of the possible features of a discussions app.',
   },
   selectApp: {
@@ -124,11 +124,6 @@ const messages = defineMessages({
     defaultMessage: 'Embedded course sections',
     description: 'The name of a discussions feature.',
   },
-  'featureName-lti': {
-    id: 'authoring.discussions.featureName-lti',
-    defaultMessage: 'LTI integration',
-    description: 'The name of a discussions feature.',
-  },
   'featureName-advanced-in-context-discussion': {
     id: 'authoring.discussions.featureName-advanced-in-context-discussion',
     defaultMessage: 'Advanced in context discussion',

diff --git a/src/pages-and-resources/discussions/data/api.js b/src/pages-and-resources/discussions/data/api.js
@@ -61,7 +61,7 @@ function normalizeApps(data) {
       accessibility: app.external_links.accessibility,
       contactEmail: app.external_links.contact_email,
     },
-    hasFullSupport: app.features.length >= data.features.length,
+    hasFullSupport: app.has_full_support,
   }));
   return {
     courseId: data.context_key,

diff --git a/src/pages-and-resources/discussions/data/redux.test.js b/src/pages-and-resources/discussions/data/redux.test.js
@@ -24,16 +24,16 @@ const featuresState = {
   'wcag-2.1': {
     id: 'wcag-2.1',
   },
-  lti: {
-    id: 'lti',
+  'lti-basic-configuration': {
+    id: 'lti-basic-configuration',
   },
 };
 
 const featureIds = [
   'discussion-page',
   'embedded-course-sections',
   'wcag-2.1',
-  'lti',
+  'lti-basic-configuration',
 ];
 
 const legacyApp = {
@@ -50,7 +50,7 @@ const legacyApp = {
     accessibility: '',
     contactEmail: '',
   },
-  hasFullSupport: false,
+  hasFullSupport: true,
   messages: [],
 };
 
@@ -60,7 +60,7 @@ const piazzaApp = {
     'discussion-page',
     'embedded-course-sections',
     'wcag-2.1',
-    'lti',
+    'lti-basic-configuration',
   ],
   externalLinks: {
     learnMore: '',
@@ -69,7 +69,7 @@ const piazzaApp = {
     accessibility: '',
     contactEmail: '',
   },
-  hasFullSupport: true,
+  hasFullSupport: false,
   messages: [],
 };
 

diff --git a/src/pages-and-resources/discussions/factories/mockApiResponses.js b/src/pages-and-resources/discussions/factories/mockApiResponses.js
@@ -6,7 +6,7 @@ export const piazzaApiResponse = {
     'discussion-page',
     'embedded-course-sections',
     'wcag-2.1',
-    'lti',
+    'lti-basic-configuration',
   ],
   lti_configuration: {
     lti_1p1_client_key: 'client_key_123',
@@ -32,14 +32,15 @@ export const piazzaApiResponse = {
           contact_email: '',
         },
         messages: [],
+        has_full_support: true,
       },
       piazza: {
         features: [
           // We give piazza all features just so we can test our "full support" text.
           'discussion-page',
           'embedded-course-sections',
           'wcag-2.1',
-          'lti',
+          'lti-basic-configuration',
         ],
         external_links: {
           learn_more: '',
@@ -49,6 +50,7 @@ export const piazzaApiResponse = {
           contact_email: '',
         },
         messages: [],
+        has_full_support: false,
       },
     },
   },
@@ -62,7 +64,7 @@ export const legacyApiResponse = {
     'discussion-page',
     'embedded-course-sections',
     'wcag-2.1',
-    'lti',
+    'lti-basic-configuration',
   ],
   lti_configuration: {},
   plugin_configuration: {
@@ -101,14 +103,15 @@ export const legacyApiResponse = {
           contact_email: '',
         },
         messages: [],
+        has_full_support: true,
       },
       piazza: {
         features: [
           // We give piazza all features just so we can test our "full support" text.
           'discussion-page',
           'embedded-course-sections',
           'wcag-2.1',
-          'lti',
+          'lti-basic-configuration',
         ],
         external_links: {
           learn_more: '',
@@ -118,6 +121,7 @@ export const legacyApiResponse = {
           contact_email: '',
         },
         messages: [],
+        has_full_support: false,
       },
     },
   },
@@ -133,7 +137,6 @@ export const emptyAppApiResponse = {
   providers: {
     active: 'legacy',
     available: {
-
     },
   },
 };