fix: remove @ts-check and move CreateContentLibraryArgs type

open-craft · Jun 25, 2024 · 8d71297 · 8d71297
1 parent 708426c
commit 8d71297
Show file tree

Hide file tree

Showing 16 changed files with 9 additions and 25 deletions.
diff --git a/src/library-authoring/EmptyStates.tsx b/src/library-authoring/EmptyStates.tsx
@@ -1,4 +1,3 @@
-// @ts-check
 import React from 'react';
 import { FormattedMessage } from '@edx/frontend-platform/i18n';
 import {

diff --git a/src/library-authoring/LibraryAuthoringPage.test.tsx b/src/library-authoring/LibraryAuthoringPage.test.tsx
@@ -1,4 +1,3 @@
-// @ts-check
 import React from 'react';
 import MockAdapter from 'axios-mock-adapter';
 import { initializeMockApp } from '@edx/frontend-platform';

diff --git a/src/library-authoring/LibraryAuthoringPage.tsx b/src/library-authoring/LibraryAuthoringPage.tsx
@@ -1,4 +1,3 @@
-// @ts-check
 import React, { useEffect, useState } from 'react';
 import { StudioFooter } from '@edx/frontend-component-footer';
 import { useIntl } from '@edx/frontend-platform/i18n';

diff --git a/src/library-authoring/LibraryCollections.tsx b/src/library-authoring/LibraryCollections.tsx
@@ -1,4 +1,3 @@
-// @ts-check
 import React from 'react';
 import { FormattedMessage } from '@edx/frontend-platform/i18n';
 

diff --git a/src/library-authoring/LibraryComponents.tsx b/src/library-authoring/LibraryComponents.tsx
@@ -1,4 +1,3 @@
-// @ts-check
 import React from 'react';
 import { FormattedMessage } from '@edx/frontend-platform/i18n';
 

diff --git a/src/library-authoring/LibraryHome.tsx b/src/library-authoring/LibraryHome.tsx
@@ -1,4 +1,3 @@
-// @ts-check
 import React from 'react';
 import { FormattedMessage } from '@edx/frontend-platform/i18n';
 import {

diff --git a/src/library-authoring/create-library/CreateLibrary.test.tsx b/src/library-authoring/create-library/CreateLibrary.test.tsx
@@ -1,4 +1,3 @@
-// @ts-check
 import React from 'react';
 import MockAdapter from 'axios-mock-adapter';
 import { initializeMockApp } from '@edx/frontend-platform';

diff --git a/src/library-authoring/create-library/CreateLibrary.tsx b/src/library-authoring/create-library/CreateLibrary.tsx
@@ -1,4 +1,3 @@
-// @ts-check
 import React, { useState } from 'react';
 import { StudioFooter } from '@edx/frontend-component-footer';
 import { FormattedMessage, useIntl } from '@edx/frontend-platform/i18n';
@@ -19,10 +18,10 @@ import FormikControl from '../../generic/FormikControl';
 import FormikErrorFeedback from '../../generic/FormikErrorFeedback';
 import { useOrganizationListData } from '../../generic/data/apiHooks';
 import SubHeader from '../../generic/sub-header/SubHeader';
+import type { CreateContentLibraryArgs } from './data/api';
 import { useCreateLibraryV2 } from './data/apiHooks';
 import messages from './messages';
 
-import type { CreateContentLibraryDto } from './data/types';
 
 const CreateLibrary = () => {
   const intl = useIntl();
@@ -74,7 +73,7 @@ const CreateLibrary = () => {
                 ),
             })
           }
-          onSubmit={async (values: CreateContentLibraryDto) => {
+          onSubmit={async (values: CreateContentLibraryArgs) => {
             setApiError(undefined);
             try {
               const data = await mutateAsync(values);

diff --git a/src/library-authoring/create-library/data/api.ts b/src/library-authoring/create-library/data/api.ts
@@ -1,20 +1,23 @@
-// @ts-check
 import { camelCaseObject, getConfig } from '@edx/frontend-platform';
 import { getAuthenticatedHttpClient } from '@edx/frontend-platform/auth';
 
-import type { CreateContentLibraryDto } from './types';
-
 const getApiBaseUrl = () => getConfig().STUDIO_BASE_URL;
 
 /**
  * Get the URL for creating a new library.
  */
 export const getContentLibraryV2CreateApiUrl = () => `${getApiBaseUrl()}/api/libraries/v2/`;
 
+export interface CreateContentLibraryArgs {
+  title: string,
+  org: string,
+  slug: string,
+}
+
 /**
  * Create a new library
  */
-export async function createLibraryV2(data: CreateContentLibraryDto) {
+export async function createLibraryV2(data: CreateContentLibraryArgs) {
   const client = getAuthenticatedHttpClient();
   const url = getContentLibraryV2CreateApiUrl();
 

diff --git a/src/library-authoring/create-library/data/apiHooks.ts b/src/library-authoring/create-library/data/apiHooks.ts
@@ -1,4 +1,3 @@
-// @ts-check
 import {
   useMutation,
   useQueryClient,

diff --git a/src/library-authoring/create-library/data/types.d.ts b/src/library-authoring/create-library/data/types.d.ts
diff --git a/src/library-authoring/create-library/messages.ts b/src/library-authoring/create-library/messages.ts
@@ -1,4 +1,3 @@
-// @ts-check
 import { defineMessages } from '@edx/frontend-platform/i18n';
 
 const messages = defineMessages({

diff --git a/src/library-authoring/data/api.ts b/src/library-authoring/data/api.ts
@@ -1,4 +1,3 @@
-// @ts-check
 import { camelCaseObject, getConfig } from '@edx/frontend-platform';
 import { getAuthenticatedHttpClient } from '@edx/frontend-platform/auth';
 

diff --git a/src/library-authoring/data/apiHook.ts b/src/library-authoring/data/apiHook.ts
@@ -1,4 +1,3 @@
-// @ts-check
 import React from 'react';
 import { useQuery } from '@tanstack/react-query';
 import { MeiliSearch } from 'meilisearch';

diff --git a/src/library-authoring/index.ts b/src/library-authoring/index.ts
@@ -1,3 +1,2 @@
-// @ts-check
 export { default as LibraryAuthoringPage } from './LibraryAuthoringPage';
 export { CreateLibrary } from './create-library';
diff --git a/src/library-authoring/messages.ts b/src/library-authoring/messages.ts
@@ -1,4 +1,3 @@
-// @ts-check
 import { defineMessages } from '@edx/frontend-platform/i18n';
 
 const messages = defineMessages({