Skip to content

Commit

Permalink
feat: wip
Browse files Browse the repository at this point in the history
  • Loading branch information
rpenido committed Oct 20, 2023
2 parents 860840b + 1925fae commit cde3d06
Show file tree
Hide file tree
Showing 10 changed files with 72 additions and 43 deletions.
2 changes: 1 addition & 1 deletion README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -310,4 +310,4 @@ Please do not report security issues in public, and email [email protected] i

.. |codecov-badge| image:: https://codecov.io/github/openedx/frontend-app-course-authoring/coverage.svg?branch=master
:target: https://codecov.io/github/openedx/frontend-app-course-authoring?branch=master
:alt: Codecov
:alt: Codecov
84 changes: 53 additions & 31 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,11 @@
"url": "https://github.com/openedx/frontend-app-course-authoring/issues"
},
"dependencies": {
"@edx/brand": "npm:@edx/brand-openedx@1.1.0",
"@edx/brand": "npm:@openedx/brand-openedx@^1.2.2",
"@edx/frontend-component-footer": "^12.3.0",
"@edx/frontend-component-header": "^4.7.0",
"@edx/frontend-enterprise-hotjar": "^1.2.1",
"@edx/frontend-lib-content-components": "1.174.0",
"@edx/frontend-lib-content-components": "1.175.0",
"@edx/frontend-platform": "4.6.3",
"@edx/paragon": "^20.45.4",
"@fortawesome/fontawesome-svg-core": "1.2.28",
Expand Down
11 changes: 7 additions & 4 deletions renovate.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"extends": [
"config:base",
"schedule:daily",
"schedule:weekly",
":rebaseStalePrs",
":semanticCommits",
":dependencyDashboard"
Expand All @@ -13,17 +13,20 @@
"rebaseStalePrs": true,
"packageRules": [
{
"extends": [
"schedule:daily"
],
"matchPackagePatterns": ["@edx", "@openedx"],
"matchUpdateTypes": ["minor", "patch"],
"automerge": false
},
{
"matchPackagePatterns": ["@edx/frontend-lib-content-components"],
"matchUpdateTypes": ["minor", "patch"],
"automerge": true,
"automerge": false,
"schedule": [
"after 9am",
"before 5pm"
"after 1am",
"before 11pm"
]
}
]
Expand Down
1 change: 1 addition & 0 deletions src/index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,5 @@
@import "course-updates/CourseUpdates";
@import "export-page/CourseExportPage";
@import "import-page/CourseImportPage";
@import "files-and-uploads/table-components/GalleryCard";
@import "taxonomy/taxonomy-card/TaxonomyCard.scss";
2 changes: 1 addition & 1 deletion src/taxonomy/index.js
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
export { default as TaxonomyListPage } from './TaxonomyListPage';
export { TaxonomyDetailPage } from './taxonomy-detail';
export { default as TaxonomyDetailPage } from './taxonomy-detail/TaxonomyDetailPage';
4 changes: 2 additions & 2 deletions src/taxonomy/taxonomy-card/TaxonomyCard.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ const TaxonomyCard = ({ className, original, intl }) => {
setIsExportModalOpen(true);
break;
default:
/* istanbul ignore next */
break;
}
};
Expand Down Expand Up @@ -95,15 +96,14 @@ const TaxonomyCard = ({ className, original, intl }) => {
isOpen={isExportModalOpen}
onClose={() => setIsExportModalOpen(false)}
taxonomyId={id}
taxonomyName={name}
/>
)}
</>
);

return (
<>
<Card className={classNames('taxonomy-card', className)} data-testid={`taxonomy-card-${id}`}>
<Card isClickable className={classNames('taxonomy-card', className)} data-testid={`taxonomy-card-${id}`}>
<Link className="stretched-link" to={`taxonomy-list/${id}`} aria-label="view taxonomy details" />
<Card.Header
title={name}
Expand Down
4 changes: 4 additions & 0 deletions src/taxonomy/taxonomy-card/TaxonomyCard.scss
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@
white-space: nowrap;
}

.pgn__card-header-actions {
z-index: 100;
}

.taxonomy-menu-item:focus {
/**
* There is a bug in the menu that auto focus the first item.
Expand Down
1 change: 1 addition & 0 deletions src/taxonomy/taxonomy-card/TaxonomyCardMenu.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ const TaxonomyCardMenu = ({
return (
<>
<IconButton
className="streched-link"
variant="primary"
onClick={() => setMenuIsOpen(true)}
ref={setMenuTarget}
Expand Down
2 changes: 0 additions & 2 deletions src/taxonomy/taxonomy-detail/index.js

This file was deleted.

0 comments on commit cde3d06

Please sign in to comment.