refactor: merges TaxonomyCardMenu and TaxonomyDetailMenu

[rpenido]

This PR merges the TaxonomyCardMenu and TaxonomyDetailMenu since both contain the same items.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (rpenido/fal-3532-import-taxonomy@4202c27). Click here to learn what that means.

Additional details and impacted files

@@                         Coverage Diff                         @@
##             rpenido/fal-3532-import-taxonomy      #13   +/-   ##
===================================================================
  Coverage                                    ?   88.82%           
===================================================================
  Files                                       ?      449           
  Lines                                       ?     6938           
  Branches                                    ?     1473           
===================================================================
  Hits                                        ?     6163           
  Misses                                      ?      750           
  Partials                                    ?       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ChrisChV]

@rpenido Would you add a menuItems like I added here. It's cleaner, and I used that to enable some menus for the system defined taxonomies.

[rpenido]

Sure @ChrisChV!

[rpenido]

Done 0fe4b3c

I moved the logic to run inside the menu (to avoid duplication). Let me know what you think.

[ChrisChV]

@rpenido Looks good to me 👍 My concern is that there are going to be conflicts with openedx#684. Won't be long until that PR is merged. So, depending on which PR is merged, one will have to fix the conflicts.

• I tested this: I tested that the menu works.
• I read through the code and considered the security, stability and performance implications of the changes.
• I tested that the UI can be used with a keyboard only (tab order, keyboard controls).
• Includes tests for bugfixes and/or features added.
• Includes documentation

[rpenido]

@rpenido Looks good to me 👍 My concern is that there are going to be conflicts with openedx#684. Won't be long until that PR is merged. So, depending on which PR is merged, one will have to fix the conflicts.

* [x]  I tested this: I tested that the menu works.

* [x]  I read through the code and considered the security, stability and performance implications of the changes.

* [x]  I tested that the UI can be used with a keyboard only (tab order, keyboard controls).

* [x]  Includes tests for bugfixes and/or features added.

* [x]  Includes documentation

Sure @ChrisChV!

As openedx#684 is on CC review, I think it is better to merge to openedx#675.

@bradenmacdonald What do you think about merging this refactor to openedx#675? It seems like they didn't start the external review.

[bradenmacdonald]

@rpenido Good point. I don't want to slow down the CC review, so it does make sense to merge this to openedx#675 . Just make sure to update that PR with master once openedx#684 merges, so we resolve all the conflicts.