-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add auto scroll to new sections when created #14
feat: add auto scroll to new sections when created #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@steff456 Nice work! Just left few suggestions and a question. Also, the tests are failing.
@navinkarkera this one is ready for a final review! All tests are passing now :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## navin/course-outline/section #14 +/- ##
===============================================================
Coverage ? 88.50%
===============================================================
Files ? 481
Lines ? 7480
Branches ? 1595
===============================================================
Hits ? 6620
Misses ? 832
Partials ? 28 ☔ View full report in Codecov by Sentry. |
@navinkarkera apparently the CI is failing to upload the coverage test, but the modified test is passing. Please let me know if there's anything I need to do on my side to fix this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@steff456 Nice work!
👍
- I tested this
- I read through the code
- I checked for accessibility issues
-
Includes documentation
8734daa
to
61ff8f4
Compare
5b39cc3
to
97ae77e
Compare
@navinkarkera I rebased this PR successfully, please let me know if there's anything else needed for this PR. |
61ff8f4
to
6567ed9
Compare
97ae77e
to
37bae58
Compare
Resolves
Private-ref
: https://tasks.opencraft.com/browse/BB-8220This PR,
utils.jsx
SectionCard
itemscroll.mp4
Depends on
Testing instructions
make cms-up
in devstack.new section
buttons available in the outline