Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add auto scroll to new sections when created #14

Merged
merged 4 commits into from
Dec 11, 2023

Conversation

steff456
Copy link

@steff456 steff456 commented Nov 29, 2023

Resolves Private-ref: https://tasks.opencraft.com/browse/BB-8220

This PR,

  • Creates a generic scroll to reference function under utils.jsx
  • Adds an effect for when the list is changed
  • Adds the reference to scroll to the last SectionCard item
scroll.mp4

Depends on

Testing instructions

@steff456 steff456 self-assigned this Nov 29, 2023
Copy link
Member

@navinkarkera navinkarkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steff456 Nice work! Just left few suggestions and a question. Also, the tests are failing.

src/course-outline/utils.jsx Outdated Show resolved Hide resolved
src/course-outline/utils.jsx Outdated Show resolved Hide resolved
@steff456
Copy link
Author

@navinkarkera this one is ready for a final review! All tests are passing now :)

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (navin/course-outline/section@2bfa367). Click here to learn what that means.

❗ Current head 97ae77e differs from pull request most recent head 37bae58. Consider uploading reports for the commit 37bae58 to get more accurate results

Additional details and impacted files
@@                       Coverage Diff                       @@
##             navin/course-outline/section      #14   +/-   ##
===============================================================
  Coverage                                ?   88.50%           
===============================================================
  Files                                   ?      481           
  Lines                                   ?     7480           
  Branches                                ?     1595           
===============================================================
  Hits                                    ?     6620           
  Misses                                  ?      832           
  Partials                                ?       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@steff456
Copy link
Author

steff456 commented Dec 4, 2023

@navinkarkera apparently the CI is failing to upload the coverage test, but the modified test is passing. Please let me know if there's anything I need to do on my side to fix this

Copy link
Member

@navinkarkera navinkarkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steff456 Nice work!

👍

  • I tested this
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

@navinkarkera navinkarkera force-pushed the navin/course-outline/section branch 4 times, most recently from 8734daa to 61ff8f4 Compare December 7, 2023 07:32
@steff456 steff456 force-pushed the stephannie/scroll-course branch from 5b39cc3 to 97ae77e Compare December 7, 2023 22:15
@steff456
Copy link
Author

steff456 commented Dec 7, 2023

@navinkarkera I rebased this PR successfully, please let me know if there's anything else needed for this PR.

@navinkarkera navinkarkera force-pushed the navin/course-outline/section branch from 61ff8f4 to 6567ed9 Compare December 11, 2023 14:35
@navinkarkera navinkarkera force-pushed the stephannie/scroll-course branch from 97ae77e to 37bae58 Compare December 11, 2023 14:43
@navinkarkera navinkarkera merged commit e8761b9 into navin/course-outline/section Dec 11, 2023
3 checks passed
@xitij2000 xitij2000 deleted the stephannie/scroll-course branch January 15, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants