Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [FC-0036] Search Content Tags #16

Conversation

yusuf-musleh
Copy link

@yusuf-musleh yusuf-musleh commented Dec 1, 2023

Description

This PR adds the the ability to search tags in the Content Tags Drawer.

Screen Shot 2023-12-04 at 1 49 05 PM

Supporting information

Related Tickets:

Testing instructions

  1. Run you local dev stack.
  2. Next, navigate to http://localhost:18010/admin/waffle/flag/ and create a new flag: new_studio_mfe.use_tagging_taxonomy_list_page make sure it is active for everyone
  3. If you don't already have sample taxonomy/tags data, follow the instructions in this repo to generate sample data: https://github.com/open-craft/taxonomy-sample-data
  4. Navigate to the sample courses and open the tags drawer for the units
  5. Check that all the taxonomies are shown in the drawer and the applied tags are shown
  6. Expand some taxonomies and click on the "Add Tags" button
  7. In the search bar, type in a term to search for in the tags
  8. Confirm that the search results contain the search term. If the root tags shown do not contain the search term, that means the term is in one its (grand)children
  9. Confirm that when you check/uncheck a tag it is reflected in the tags tree
  10. Confirm that if you check a tag, all its ancestors become implicit
  11. Confirm when you uncheck a tag and it is the only child, all its ancestors get unchecked
  12. Confirm that the tags number gets updated correctly whenever you add/remove tags

Private-ref: FAL-3572

@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/search-content-tags branch from dd96c20 to 21db528 Compare December 3, 2023 13:12
@yusuf-musleh yusuf-musleh changed the title [WIP] Search Content Tags [WIP] [FC-0036] Search Content Tags Dec 4, 2023
@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/content-tags-drawer-editing branch from f35727e to 8d1f7e9 Compare December 4, 2023 14:20
@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/search-content-tags branch from 4758625 to 9306cae Compare December 7, 2023 15:35
@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/content-tags-drawer-editing branch from cae319e to ae22fb1 Compare December 8, 2023 07:44
yusuf-musleh and others added 9 commits December 8, 2023 13:55
This commit adds the add/remove functionality of content tags where the
state is stored and changes are updated in the backend through the API.
Changes are reflected in the UI automatically.
This adds support for pre-loading taxonomy tags if they fit within the
threshold to avoid making exessive requests, while still maintaining
support for loading more paginated results.
@yusuf-musleh
Copy link
Author

Closing in favor of openedx#737 to merge to main repo since the base of this PR cannot be changed to main repo. cc: @bradenmacdonald

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants