Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: subsection list #20

Merged

Conversation

navinkarkera
Copy link
Member

@navinkarkera navinkarkera commented Dec 7, 2023

Description: This PR adds subsection component which enables UI to display subsections under each section. It also adds functionality for adding new subsections, duplicating, deleting and publishing subsections. We also try to reuse section list as much as possible.

Private-ref: https://tasks.opencraft.com/browse/BB-8221

Dependents on:

Testing instructions:

Screenshot:

image

@navinkarkera navinkarkera requested a review from CefBoud December 7, 2023 15:50
@navinkarkera navinkarkera self-assigned this Dec 7, 2023
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (navin/course-outline/section@e8761b9). Click here to learn what that means.

❗ Current head 11c3362 differs from pull request most recent head a1d87c1. Consider uploading reports for the commit a1d87c1 to get more accurate results

Additional details and impacted files
@@                       Coverage Diff                       @@
##             navin/course-outline/section      #20   +/-   ##
===============================================================
  Coverage                                ?   88.18%           
===============================================================
  Files                                   ?      483           
  Lines                                   ?     7586           
  Branches                                ?     1608           
===============================================================
  Hits                                    ?     6690           
  Misses                                  ?      867           
  Partials                                ?       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@CefBoud CefBoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on this, @navinkarkera !

@navinkarkera navinkarkera force-pushed the navin/course-outline/subsection branch 2 times, most recently from 0ae0442 to 11c3362 Compare December 8, 2023 11:19
@navinkarkera navinkarkera force-pushed the navin/course-outline/section branch from 61ff8f4 to 6567ed9 Compare December 11, 2023 14:35
@navinkarkera navinkarkera force-pushed the navin/course-outline/subsection branch from 11c3362 to 2112fe2 Compare December 11, 2023 15:06
@navinkarkera navinkarkera force-pushed the navin/course-outline/subsection branch from 2112fe2 to 4e30ebf Compare December 11, 2023 15:19
@navinkarkera navinkarkera merged commit a4567ff into navin/course-outline/section Dec 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants