feat: adds sort widget to search manager and library component page [FC-0059] #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When lib mode is set to "mixed", both "Libraries" and "Legacy Libraries" tabs are show in the Studio Home. When "Libraries" is clicked, v2 libraries are fetched, when "Legacy Libraries" is clicked, v1 libraries are fetched. When lib mode is set to "v1 only" or "v2 only", only one tab "Libraries" is show and only the respective libraries are fetched when the tab is clicked.
This is to switch between different library modes.
The path updates when selecting tabs, when accessing the url with the path directly it will open its respective tab. Navigating using the browser back/forward buttons is also supported.
This commit is temporary as the current frontend build system in tests doesnt support TS syntax. That should be fixed soon, and this commit should be removed.
This is a temporary commit since there are currently no webpack loaders that support tsx files in the test running. This commit should be removed once that is fixed upstream.
When lib mode is set to "mixed", both "Libraries" and "Legacy Libraries" tabs are show in the Studio Home. When "Libraries" is clicked, v2 libraries are fetched, when "Legacy Libraries" is clicked, v1 libraries are fetched. When lib mode is set to "v1 only" or "v2 only", only one tab "Libraries" is show and only the respective libraries are fetched when the tab is clicked.
This is to switch between different library modes.
The path updates when selecting tabs, when accessing the url with the path directly it will open its respective tab. Navigating using the browser back/forward buttons is also supported.
This commit is temporary as the current frontend build system in tests doesnt support TS syntax. That should be fixed soon, and this commit should be removed.
This is a temporary commit since there are currently no webpack loaders that support tsx files in the test running. This commit should be removed once that is fixed upstream.
…753-library-home-page-bare-bones
…nido/fal-3764-library-home-filter-by-content-type
Type 'ReactElement<any, string | JSXElementConstructor<any>>' is not assignable to type 'ComponentType<{}> | undefined'.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rpenido/fal-3764-library-home-filter-by-content-type #51 +/- ##
========================================================================================
+ Coverage 92.65% 92.68% +0.02%
========================================================================================
Files 696 693 -3
Lines 12365 12339 -26
Branches 2707 2694 -13
========================================================================================
- Hits 11457 11436 -21
+ Misses 876 872 -4
+ Partials 32 31 -1 ☔ View full report in Codecov by Sentry. |
|
@yusuf-musleh I will address this point on the ticket today by modifying the SearchContext:
... and I'll add tests :) |
|
@pomegranited This is looking great so far! I've tested it out and its working quite well. I like the use of an enum for the sort options, very clean. And this PR would definitely make things easier for me working on the "Recently Modified" section. |
using a re-usable custom hook. Also fixed type/lint errors/console warnings.
…nto jill/FAL-3758-sort-components
fixes failing test
on the LibraryAuthoringPage.
rpenido
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
LGTM 👍
Thank you for your great work here @pomegranited. I liked the useStateWithUrlSearchParam hook. Very elegant!
- I tested this using the instructions from feat: adds sort widget to search manager and library component page [FC-0059] openedx/frontend-app-authoring#1147
- I read through the code
- I checked for accessibility issues
- Includes documentation
| * search parameter when returning/setting the state variable. | ||
| * | ||
| */ | ||
| function useStateWithUrlSearchParam<Type>( |
There was a problem hiding this comment.
Liked this! Good work @pomegranited !
Co-authored-by: Rômulo Penido <[email protected]>
* feat: Add Recently Modified library section * feat: Add "View All" to library sections The "View All" action appears on sections that pass in a view all action and contain content that exceeds the defined preview limit, which defaults to 4. * feat: Use intl library section titles * test: Update tests
There's still a difference with the arrow icon used -- DropDown uses a css-generated hollow caret, but the filters use the svg solid caret Icon.
rpenido
force-pushed
the
rpenido/fal-3764-library-home-filter-by-content-type
branch
2 times, most recently
from
3d66e47 to
317c3e7
Compare
|
Closed in favour of openedx#1147 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please use this PR for code review.
See openedx#1147 for testing instructions.
Private-ref: FAL-3758