-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update MFE to use dynamically injected theme #55
Conversation
d2b2de2
to
81fd3b1
Compare
Updates the MFE to use alpha version of frontend build, platform and paragon to support runtime theming.
d7e6235
to
71a97cc
Compare
71a97cc
to
bcecfb8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## asu-moe/redwood-css #55 +/- ##
======================================================
Coverage ? 92.43%
======================================================
Files ? 708
Lines ? 12539
Branches ? 2731
======================================================
Hits ? 11591
Misses ? 913
Partials ? 35 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- I tested that http://localhost:9100/light.min.css is being loaded and theming being applied.
- I read through the changes.
// TODO | ||
// await waitFor(() => expect(window.location.pathname).toEqual(`/course/${courseId}/pages-and-resources`)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we going to resolve this (and another one) TODO items?
Description
Updates the MFE to use alpha version of frontend build, platform and paragon to support runtime theming.
Supporting information
https://openedx.atlassian.net/wiki/spaces/BPL/pages/3770744958/Migrating+MFEs+to+Paragon+design+tokens+and+CSS+variables
Testing instructions
artur/design-tokens-update
.npm ci && npm run build
).dist
directory (e.g.python3 -m http.server 9100
, use same port forbrandOverride
in MFE_CONFIG below).http://localhost:9100/light.min.css
was loaded.Example Tutor plugin to set MFE_CONFIG
Deadline
ASAP
Other information
Internal-ref: https://tasks.opencraft.com/browse/BB-9023