Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: discussion setting and release & due date setting (#976) #60

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

DanielVZ96
Copy link
Member

Cherry pick fixes:

  • fix: hide release and due dates config in self paced courses

  • feat: discussion enable setting for unit in outline

  • refactor: message text

  • fix: modal dialog overflow


Testing

  • In the CMS, go to through all tabs for configuration on a subsection, and cofirm it renders correctly (zoom in and out of the page too because in high res screens the issue may not appear)

before

image

after

image

* fix: hide release and due dates config in self paced courses

* feat: discussion enable setting for unit in outline

* refactor: message text

Co-authored-by: Kristin Aoki <[email protected]>

* fix: modal dialog overflow

---------

Co-authored-by: Kristin Aoki <[email protected]>
@DanielVZ96 DanielVZ96 requested a review from Cup0fCoffee August 26, 2024 23:29
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.45%. Comparing base (f336daa) to head (52d33b3).
Report is 5 commits behind head on asu-moe/redwood-css.

Files with missing lines Patch % Lines
src/generic/configure-modal/UnitTab.jsx 92.85% 1 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           asu-moe/redwood-css      #60      +/-   ##
=======================================================
+ Coverage                92.43%   92.45%   +0.01%     
=======================================================
  Files                      708      708              
  Lines                    12539    12547       +8     
  Branches                  2690     2696       +6     
=======================================================
+ Hits                     11591    11600       +9     
+ Misses                     913      912       -1     
  Partials                    35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cup0fCoffee
Copy link
Member

👍

  • I tested this
  • I read through the code
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.

@kaustavb12 kaustavb12 merged commit 9719b2a into asu-moe/redwood-css Aug 31, 2024
5 checks passed
@kaustavb12 kaustavb12 deleted the dvz/cherry-pick-modal-fix branch August 31, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants