Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use configured DEFAULT_GRADE_DESIGNATIONS #62

Merged

Conversation

xitij2000
Copy link
Member

@xitij2000 xitij2000 commented Aug 30, 2024

Support was recently added to edx-platform to add customisised default grade designations, this change adds support for them to this MFE as well to bring it to partiy with the edx-platform UI

It also refactors the grading-settings page to use React Query and updates the logic used when partitioning grades by default to make it work better when there are more than 5 partitions.

backport of openedx#1227

Support was recently added to edx-platform to add customisised default grade
designations, this change adds support for them to this MFE as well to bring it
to partiy with the edx-platform UI

It also refactors the grading-settings page to use React Query and updates the
logic used when partitioning grades by default to make it work better when there
are more than 5 partitions.
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.54%. Comparing base (4584d6a) to head (acbd7fa).
Report is 6 commits behind head on asu-moe/redwood-css.

Files with missing lines Patch % Lines
...rc/grading-settings/grading-scale/GradingScale.jsx 60.00% 4 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           asu-moe/redwood-css      #62      +/-   ##
=======================================================
+ Coverage                92.44%   92.54%   +0.09%     
=======================================================
  Files                      708      706       -2     
  Lines                    12541    12515      -26     
  Branches                  2726     2728       +2     
=======================================================
- Hits                     11594    11582      -12     
+ Misses                     912      898      -14     
  Partials                    35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cup0fCoffee
Copy link
Member

👍

  • I tested this: switched the branch and tested that setting DEFAULT_GRADE_DESIGNATION to more than 5 elements correctly works in UI
  • I read through the code
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.

@xitij2000 xitij2000 merged commit 7324297 into asu-moe/redwood-css Sep 2, 2024
4 of 5 checks passed
@xitij2000 xitij2000 deleted the kshitij/use-custom-grade-range-redwood branch September 2, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants