feat: shareable URLs for library components and searches [FC-0076] #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dima Alipov <[email protected]>
* feat: fixed fields onblur * feat: fixed fields onblur * feat: added new tests
This PR adds a new configuration flag that shows/hides tabs in studio home along with some new functionality around to V1 and V2 Libraries. When the new LIBRARY_MODE flag is set to "mixed" (default in dev) it will show "Libraries" and "Legacy Libraries" tabs that correspond to v1 and v2 tabs respectively. When the new LIBRARY_MODE flag is set to "v1 only" (default in production) or "v2 only", only one tab "Libraries" is shown and only the respective libraries are fetched when the tab is clicked. In addition to the above changes, the URL/route now updates when clicking on the tabs, and navigating to it directly would open up that tab as well as a new placeholder page that you will be redirected to when clicking on a v2 library if the library authoring MFE is not enabled.
* feat: Include org filter when requesting LTI providers * chore: Created silent version for CI testing to avoid log flooding
* fix: warnings about Duplicate message id * fix: paragon's Hyperlink no longer accepts a 'content' attribute * test: ensure all act() calls are async * test: Removed "async" from "describe" * fix: DiscussionsSettings tests * Don't nest userAction.click in act() -- nested act() statements have indeterminent behaviour. * Use getBy* instead of findBy* with userAction to avoid nested act() statements * Always await userEvent.click * Use fireEvent.click when the onClick handlers need to be called * Use queryBy* instead of getBy* when using .toBeInTheDocument or * fix: typo in data-testid * test: Use useLocation to test route changes * Don't nest userAction.click in act() -- nested act() statements have * chore: fix lint:fix and lint errors * remove "indent" setting from .eslintrc.js * add @typescript-eslint/ prefix to eslint-disable-line statements where flagged by linter * changed stylelint setting import-notation to "string" * test: fix failing tests after upgrade * fix: css error "target selector was not found" * chore: upgrades dependency [email protected] * chore: bumps @edx/frontend-component-ai-translations to ^2.1.0 --------- Co-authored-by: Yusuf Musleh <[email protected]>
…v2.4.0 (openedx#1118) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* feat: add upload progress modal * fix: increase code coverage * fix: fix code to be more readable * fix: delete empty file
This reverts commit 8ef804b.
This reverts commit f3ae225.
…prove-asset-loading Revert "feat: improve asset loading"
…v2.4.1 (openedx#1132) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* feat: add upload progress modal * fix: increase code coverage * fix: fix code to be more readable * fix: delete empty file * fix: failing test and lint * fix: progress bar not updating * feat: add missing abort controller on POST to edxVal
* chore: convert all 'search-modal' code to TypeScript * fix: lint should check .ts[x] files too * fix: remove unused dependency meilisearch-instantsearch
* fix: update initialize to only call required functions * feat: update asset urls without asset object * feat: add pagination to select image modal * fix: lint errors * chore: update tests * fix: asset pattern regex match * feat: update pagination to be button to prevent page skipping * fix: e.target.error for feedback fields * fix: failing snapshots * fix: new simple problem load error
…x#1133) * fix: update mapToStateProps to match changes in TinyMceWidget * feat: bump frontend-lib-content-components
* fix: pasting and images only insert at beginning * fix: add image click not showing gallery * chore: increase code coverage
…v2.4.3 (openedx#1140) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
openedx#1121) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ents to …" (openedx#1142) This reverts commit cdc9af2.
* fix(deps): update dependency @openedx/paragon to v22.6.1 * fix: lint errors from stricter types in new paragon version --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Hunia Fatima <[email protected]>
Added alert message if 403 error occurs.
The following bugs were found with the TinyMCE aux modal (used in emoticons, formulas and embed iframe): * The TinyMCE aux modal and the Editor modal close when clicking on any content in the aux modal. * When the user opens the Edit Source Code modal, this adds data-focus-on-hidden to the TinyMce aux modal, making it unusable (not clickable). * Since they are two separate modals, the focus remains on the editor modal, making it impossible to use scrolling or inputs from the modal aux. Solution: Move the aux modal inside the editor modal. One discarded solution: Block the modal editor from closing when interacting with the modal aux. The modal editor still retained focus.
…x#1481) When using the library component picker, show the correct number on component count (published components) in collection cards.
The page relied on obscure behavior of setting "isLibrary" to disable image uploads even in a course context. This commit refactors to use an explicit enableImageUpload prop in TinyMceWidget.
…#1506) Creates a new preview library block modal. Intercepts the message when the block is iframed to open the new modal.
…nedx#1522) Fix for: If you have a unit with many components and a problem bank on the NEW MFE unit page (with an iframe), clicking "Add Components" will open a modal that's way too tall.
...by bumping frontend-component-header 5.7.0 -> 5.8.0 Our reasoning is that the two functions of the Studio Maintenance dashboard (Announcements and Maintenance Banner) have been broken for a while. It's actually version 5.7.2 that removes the link [1] but since 5.8.0 has no breaking changes, it seemed prudent to jump straight to latest. [1] https://github.com/openedx/frontend-component-header/releases/v5.7.2 Related PR: openedx/edx-platform#35852
* Converts some files from .js or .mjs to .ts * Moves the API code from src/taxonomy/tag-list/data into src/taxonomy/data * Cleans up and improves some type definitions * No user-visible changes / functionality changes.
* Converts some files from .js or .mjs to .ts * Refactors some tests to use the new initializeMocks helper * Cleans up and improves some type definitions
In the library home page, makes the selected tab on the sidebar persist while selecting Components or Collections Info Sidebar.
…1537) It starts to add type information to the messy Redux state used by the editors, mostly focusing on the state shared by all editors and the problem editor.
…nedx#1543) Updates the message error when the user doesn't exist when adding a new team member to a library.
* Makes the Active Tab Key independent from the URL, except for the initial load, where the active tab is set from the url. *Avoids unnecessarily changing SearchParams: Due to a limitation of the useSearchParams react hook, which uses a memoized value for the URL that becomes stale after selecting a tab, it unexpectedly changes the URL value. Unfortunately there's no way to completely avoid this, so if there's a usageKey url param, the hook setter function will be called and the URL will revert to the stale memoized url.
When active/archived filters were on or there was selected any order filter, the search skipped these values and it was just returned the courses list without the respective filters. Additionally, when a search keyword was applied and a filter was selected, the keyword stayed stuck and the search list returned were not the appropriate
Split the library context into smaller contexts: * LibraryContext * ComponentPickerContext * SidebarContext
Allows library authors to undo component deletion by displaying a toast message with an undo button for some duration after deletion.
to support optional parameters in test paths
* Restructure LibraryLayout so that LibraryContext can (optionally)
useParams() to initialize its componentId/collectionId instead of
having to parse route strings.
This behavior can be disabled for the content pickers by passing
initializeFromUrl={false} to the LibraryContext.
* Add useLibraryRoutes() hook so components can easily navigate to the
best available route without having to know the route strings or
maintain search params.
Also moved ContentType declaration to the new routes.ts to avoid
circular imports.
* Clicking/selecting a ComponentCard/CollectionCard navigates to an
appropriate component/collection route given the current page.
* Rename openInfoSidebar to openLibrarySidebar, so that openInfoSidebar
can be used to open the best sidebar for a given
library/component/collection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe what this pull request changes, and why. Include implications for people using this change.
Design decisions and their rationales should be documented in the repo (docstring / ADR), per
Useful information to include:
Use cases covered (some still to do):
Supporting information
See openedx#1499
Private-ref: FAL-3984
Testing instructions
Please provide detailed step-by-step instructions for testing this change.
TBD -- include content picker checks too.