merged with dev

.github/workflows/test.yml

@@ -37,6 +37,11 @@ jobs:
   forge:
     name: Run Unit and E2E Tests
     runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        node-version: [20.x]
+
     steps:
       - uses: actions/checkout@v3
         with:
@@ -46,15 +51,16 @@ jobs:
         uses: foundry-rs/foundry-toolchain@v1
         with:
           version: nightly
+          cache: true
 
       - name: Install forge dependencies
         run: forge install
 
       - name: Install yarn dependencies
         run: yarn install --frozen-lockfile
 
-      - name: Precompile using 0.8.19 and via-ir=false
-        run: yarn build
+      - name: Build 
+        run: forge build
 
       - name: "Create env file"
         run: |
@@ -68,30 +74,3 @@ jobs:
       - name: Run tests
         shell: bash
         run: yarn test
-
-  # coverage:
-  #   name: Run Coverage Tests
-  #   runs-on: ubuntu-latest
-
-  #   strategy:
-  #     matrix:
-  #       node-version: [16.x]
-
-  #   steps:
-  #     - uses: actions/checkout@v3
-  #     - name: Use Node.js
-  #       uses: actions/setup-node@v3
-  #       with:
-  #         node-version: ${{ matrix.node-version }}
-  #         cache: "yarn"
-  #     - name: Install Foundry
-  #       uses: foundry-rs/foundry-toolchain@v1
-  #       with:
-  #         version: nightly
-  #     - run: yarn install
-  #     - run: yarn build
-  #     - run: yarn coverage
-  #     - uses: codecov/codecov-action@v3
-  #       with:
-  #         files: ./coverage/lcov.info
-  #         flags: production

.gitignore

@@ -22,6 +22,7 @@ lcov.info
 !/**/.gitkeep
 .vscode/
 
+
 # Docs build files
 docs/book
 docs/src/src/

README.md

@@ -265,7 +265,11 @@ Template: [`new-AddCollateral.json`](gov-input/anvil/new-AddCollateral.json)
     - delayedOracle: Usually a DelayedOracle that enforces delays to fresh price feeds.
     - safetyCRatio: RAY, CRatio used to compute the 'safePrice' - the price used when generating debt in SAFEEngine.
     - liquidationCRatio: RAY, CRatio used to compute the 'liquidationPrice' the price used when liquidating SAFEs.
-
+- CollateralAuctionHouseParams:
+    - maximumDiscount: WAD,  Maximum discount at which collateral is being sold
+    - minimumBid: WAD, Minimum acceptable bid
+    - minimumDiscount: WAD, Minimum discount at which collateral is being sold
+    - perSecondDiscountUpdateRate: RAY, Rate at which the discount will be updated in an auction.
 This script proposes adding a new collateral to the system (deploys new contracts via the collateral join, collateral auction house factories and it adds the correct authorizations to the needed contracts).
 
 ### Modify Parameters