-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compare dev > main #681
Open
pi0neerpat
wants to merge
105
commits into
main
Choose a base branch
from
dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Compare dev > main #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* removed extra 'startBroadcast' line * added mainnet output folder * Add 38305117 proposal --------- Co-authored-by: Patrick Gallagher <[email protected]>
add target to codecov
* modified updateTimeDelay script to go through regular governance channels * created new proposal * tested full flow on anvil * generated updateTimeProposal for mainnet * linted
* added Modifiable per collateral script. tested full flow on anvil * added missing files * Removed RETH
* Update ODGovernor to be compatible with OZv4.9.6 * Add relayers and salts * Added ARB coinjoin delegation, skipping relayer factories already deployed * Update readme and license * Update PI settings * Update mainnet params * fix vault721 auths * v1.7.0 * Ensure delegation in coinjoin * update arb delegatable cjoin * Update salts * add mainnet deployment output * Add MainnetContracts.s.sol * verified deployment * Cleanup deploy logic * reduce fuzz runs, increase max rejections * reduce vm.assumes in test_Revert_IntOverflow_1 test --------- Co-authored-by: Patrick Gallagher <[email protected]> Co-authored-by: Hunter King <[email protected]>
* Update ODGovernor to be compatible with OZv4.9.6 * Add relayers and salts * Added ARB coinjoin delegation, skipping relayer factories already deployed * Update readme and license * Update PI settings * Update mainnet params * fix vault721 auths * v1.7.0 * Ensure delegation in coinjoin * update arb delegatable cjoin * Update salts * add mainnet deployment output * Add MainnetContracts.s.sol * verified deployment * Add script DeployVault721Mainnet * pulling rebase * removed extra 'startBroadcast' line * added mainnet output folder * updated ModifyParameters.json just need to paste in the new SafeManager address in the data field * updated address in modify params json * add redeploy script * deleted enter system from basic actions * edit log text * added mainnet deployment verification script and updated the mainnetparams.s.sol to match what's in the hack md. * missing files added and linted * adjusted for correct params, uncommented commented script. clean up. * added a couple more console logs for clarity * Update name and Symbol * Cleanup deploy logic * Update registry to avoid create2 collision * Update audits * 4 21 24 deployment (#643) * Update ODGovernor to be compatible with OZv4.9.6 * Add relayers and salts * Added ARB coinjoin delegation, skipping relayer factories already deployed * Update readme and license * Update PI settings * Update mainnet params * fix vault721 auths * v1.7.0 * Ensure delegation in coinjoin * update arb delegatable cjoin * Update salts * add mainnet deployment output * Add MainnetContracts.s.sol * verified deployment * Cleanup deploy logic * reduce fuzz runs, increase max rejections * reduce vm.assumes in test_Revert_IntOverflow_1 test --------- Co-authored-by: Patrick Gallagher <[email protected]> Co-authored-by: Hunter King <[email protected]> * add links to reports * add revoke script (#652) * add revoke script * added safeEngine modifyParams * add yarn commands * follow contracts naming pattern * add deployStaticOracle script * Redeploy vault 721 * deployed vault721, intialized, deployed safemanager * vault721 and static oracle deploy * Update MainnetContracts.s.sol * Remove unused proposal * Remove unused proposals * Add UpdateOracles script * Add update stability fee * Add back CHAINLINK_CBETH_ETH_FEED * Fix failing test for RedeployVault721 --------- Co-authored-by: jschiarizzi <[email protected]> Co-authored-by: MrDeadCe11 <[email protected]> Co-authored-by: Hunter King <[email protected]> Co-authored-by: huntrr <[email protected]>
* add script * add proxy var
* modified updateTimeDelay script to go through regular governance channels * created new proposal * tested full flow on anvil * generated updateTimeProposal for mainnet * linted * running through test proposals * added mainnet contracts file * cleaned up addCOllateral json. * removing addresses * cleaning up input files * added some js to clean the added addresses out of the input json after the output is generated. * adjusted the bash * adding to readme. * more readme * format gov-input json during stringify * fixed repayDebt function call passing in true as _nonSafeHandlerAddress * added --auto tag option to -g * finishing up the readme * more readme-ing * moved gov scripts to scripts folder * linted * merged with dev * Update readme * undoing unintended changes --------- Co-authored-by: Patrick Gallagher <[email protected]>
* fixed repayDebt function call passing in true as _nonSafeHandlerAddress * add proxy singleton script (#657) * add script * add proxy var * Add deploy BasicActions * moved taxSingle to get called immediatly before modifySafeCollateral in basicActions.sol * Add script RepayDebtMainnet * Add MainnetScripts * Add TransferVaultMainnet * added a script to open a safe and lock debth with a RETH whale on a mainnet fork on anvil * fixed TestRepay script to work on anvil fork with a reth whale. this one works good. * fixed repayDebt in basic actions to not overflow * remove uneccesary int conversion * removed commented lines and cleaned up other comments * linted * Add DepositMainnet * Gov script improvements (#653) * modified updateTimeDelay script to go through regular governance channels * created new proposal * tested full flow on anvil * generated updateTimeProposal for mainnet * linted * running through test proposals * added mainnet contracts file * cleaned up addCOllateral json. * removing addresses * cleaning up input files * added some js to clean the added addresses out of the input json after the output is generated. * adjusted the bash * adding to readme. * more readme * format gov-input json during stringify * fixed repayDebt function call passing in true as _nonSafeHandlerAddress * added --auto tag option to -g * finishing up the readme * more readme-ing * moved gov scripts to scripts folder * linted * merged with dev * Update readme * undoing unintended changes --------- Co-authored-by: Patrick Gallagher <[email protected]> --------- Co-authored-by: huntrr <[email protected]> Co-authored-by: Patrick Gallagher <[email protected]>
* add saviour gas burner * lint * Update gasLimit to 3_000_000 --------- Co-authored-by: Patrick Gallagher <[email protected]>
…contracts into nfv-stabilityFee
Refactor Cast-Tokens Function
Address Library & Common Test-Setup Functions
Fix SafetyPrice for ARB on forknet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.