Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do Not Merge] ERC7496Adapter #689

Closed
wants to merge 4 commits into from
Closed

[Do Not Merge] ERC7496Adapter #689

wants to merge 4 commits into from

Conversation

daopunk
Copy link
Member

@daopunk daopunk commented May 8, 2024

I guessing this will go in a different repo, but since the contracts package is not finished, I made it here for now for the sake of review.

@daopunk daopunk requested a review from pi0neerpat May 8, 2024 00:48
@daopunk daopunk requested a review from MrDeadCe11 May 8, 2024 00:51
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 95.61%. Comparing base (3d31abf) to head (2d27158).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #689      +/-   ##
==========================================
- Coverage   96.51%   95.61%   -0.90%     
==========================================
  Files          58       59       +1     
  Lines        1921     1939      +18     
==========================================
  Hits         1854     1854              
- Misses         67       85      +18     
Files Coverage Δ
src/contracts/adapters/ERC7496Adapter.sol 0.00% <0.00%> (ø)

@daopunk daopunk closed this May 8, 2024
@daopunk
Copy link
Member Author

daopunk commented May 8, 2024

move to od-seaport-zone

@daopunk daopunk deleted the dynamic-trait-adapter branch May 9, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant