Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SafeManager Interface #693

Merged
merged 1 commit into from
May 10, 2024
Merged

Fix SafeManager Interface #693

merged 1 commit into from
May 10, 2024

Conversation

daopunk
Copy link
Member

@daopunk daopunk commented May 9, 2024

Add function liquidationEngine() external view returns (address _liquidationEngine);

@daopunk daopunk added the ch-35 label May 9, 2024
@daopunk daopunk requested a review from pi0neerpat May 9, 2024 22:39
@daopunk
Copy link
Member Author

daopunk commented May 9, 2024

@pi0neerpat how do we update this in the @open-dollar package?

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.61%. Comparing base (4597b99) to head (db72c32).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #693   +/-   ##
=======================================
  Coverage   96.61%   96.61%           
=======================================
  Files          58       58           
  Lines        1921     1921           
=======================================
  Hits         1856     1856           
  Misses         65       65           

@pi0neerpat
Copy link
Member

pi0neerpat commented May 9, 2024

You can deploy using "Run workflow" against any branch. The version will be output in the logs, or you can just use the first 8 characters of the commit eg @opendollar/contracts: 0.0.0-db72c32

https://github.com/open-dollar/od-contracts/actions/workflows/export-abis.yml

@daopunk daopunk merged commit 08c9353 into dev May 10, 2024
5 checks passed
@daopunk daopunk deleted the fix-safeManager-proxy branch May 10, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants