Convert to Python package #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert this package from CMake-based build to pure Python. For this, the xacro files are now build using a custom build command in setup.py This change will make it possible to publish robot_properties_fingers on PyPI, so that trifinger_simulation can depend on it and thus won't need to mirror the model files anymore.
Previously mypy was somehow confusing the "xacro" folder with the "xacro" package...
For some reason, this is needed for `colcon test`, see comment.
Add a test workflow that installs the package with pip and then runs the tests.
This will return the root directory of the URDF files. Currently it's the same as "one", but I think it's better to have an explicit name for it. It's also more future proof, in case the "one" files are moved at some point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Convert this package from CMake-based build to pure Python. For this, the xacro files are now build using a custom build command in setup.py
This change will make it possible to publish robot_properties_fingers on PyPI, so that trifinger_simulation can depend on it and thus won't need to mirror the model files anymore.
How I Tested
pip install ., verifying that all files are installed to the right place