-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util/docker-container: create docker container #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
util/docker-container/Dockerfile
Outdated
RUN apt-get update -y | ||
RUN apt-get install -y gcc gcc-multilib nasm make build-essential | ||
RUN apt-get install -y binutils | ||
RUN apt-get install -y gdb | ||
RUN apt-get install -y vim nano | ||
RUN apt-get install -y tmate | ||
RUN apt-get install -y python2.7 | ||
RUN apt-get install -y python3.10 python-is-python3 | ||
|
||
CMD [ "bash" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RUN apt-get update -y | |
RUN apt-get install -y gcc gcc-multilib nasm make build-essential | |
RUN apt-get install -y binutils | |
RUN apt-get install -y gdb | |
RUN apt-get install -y vim nano | |
RUN apt-get install -y tmate | |
RUN apt-get install -y python2.7 | |
RUN apt-get install -y python3.10 python-is-python3 | |
CMD [ "bash" ] | |
RUN apt-get update \ | |
&& apt-get install -y \ | |
gcc \ | |
gcc-multilib \ | |
nasm \ | |
make \ | |
build-essential \ | |
binutils \ | |
gdb \ | |
vim \ | |
nano \ | |
tmate \ | |
python2.7 \ | |
python3.10 \ | |
python-is-python3 \ | |
&& apt-get clean \ | |
&& rm -rf /var/lib/apt/lists/* | |
CMD [ "bash" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some best practices about Dockerfile. We need to put all these commands inside a single one in order to have fewer layers.
Why are you adding this here? It will generate merge conflicts and not be available for the cs-pub-ro repo [1] until we sync them. I think it's best to do the development on our fork [1] and then periodically sync it [1] with this one via a PR bot such as [2]. [1] https://github.com/cs-pub-ro/hardware-software-interface/ |
Adds a Dockerfile and all the other necessary files for the `hsi-runner`. Signed-off-by: Popa Ioan Alexandru <[email protected]>
e8b048b
to
0103288
Compare
OK, @ALEX11BR , I think @teodutu is right, sorry for confusion. |
adds a dockerfile for this course's docker container
Prerequisite Checklist
Description of changes