lab/software-stack: Add missing -fno-builtin flag in Makefile #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current link in lab-setup.md points to https://github.com/open-education-hub/operating-systems. This commit changes the link to https://github.com/cs-pub-ro/operating-systems. Signed-off-by: Elena Mihailescu <[email protected]>
Add grading rules for the Operating Systems course. Signed-off-by: Alex Apostolescu <[email protected]> Signed-off-by: Razvan Deaconescu <[email protected]>
Word should be past participle, not syscall name. Signed-off-by: PetruCristian <[email protected]>
Update `README.md` with current structure of directory (e.g. use `src/` instead of `libc/`). Detail use of `grade.sh` and `make lint`. Signed-off-by: Razvan Deaconescu <[email protected]>
The `grade.sh` script computes the final project grade, from two components: checker output and style checking. Currently, checker output provides a maximum of 90 points and style checking an output of maximum 10 points, for a total maximum of 100 points. Script it to be symlinked to the `tests/` directory of each project. It invokes the `check` rule and the `lint` rule in the tests Makefile, then proceeds to compute the summary result. Signed-off-by: Razvan Deaconescu <[email protected]>
Qemu seems to be the most suitable choice for running the operating-systems VM on macOS (at least on M1 systems). Add instructions and scripts for running the VM on macOS. Signed-off-by: Razvan Virtan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing
-fno-builtinflag from Makefile caused the compiler to substitutestr*calls fromcontent/chapters/software-stack/lab/support/common-functions/main_stringinstead of use custom implementations fromcontent/chapters/software-stack/lab/support/common-functions/string.c.