feat: make client test independet from the api #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bernd Warmuth <[email protected]>
Signed-off-by: Bernd Warmuth <[email protected]>
Signed-off-by: Bernd Warmuth <[email protected]>
When triggering an evaluation while the provider is in "not ready" or "fatal state" the sdk shall return an appropriate error. Signed-off-by: Bernd Warmuth <[email protected]>
Signed-off-by: Bernd Warmuth <[email protected]>
Signed-off-by: Bernd Warmuth <[email protected]>
Signed-off-by: Bernd Warmuth <[email protected]>
aepfli
force-pushed
the
feat/improve_client_test
branch
from
e0cc2d3
to
6dabed6
Compare
aepfli
commented
Nov 9, 2024
aepfli
commented
Nov 9, 2024
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
aepfli
force-pushed
the
feat/improve_client_test
branch
from
6dabed6
to
0a9f40b
Compare
…_test Signed-off-by: Simon Schrottner <[email protected]>
aepfli
force-pushed
the
feat/improve_client_test
branch
from
49f35f9
to
35bffcd
Compare
|
@open-feature/sdk-golang-maintainers @open-feature/sdk-golang-approvers @toddbaert @warber @beeme1mr as #299 is merged, I also do think this is ready to be reviewed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our client_test is not a unit test; we rely on the API to set the provider regularly, and within the code, we rely on the singleton. With these changes, we mock the API interface and provide it to the client's existing factory method. So each of the tests is independent from the others.
There are still some tests, which i would rather declare as e2e or integration tests, which i did not tackle, or where i do think it makes sense to keep them as is.