refactor: Rename shutdown event to notready event (#97)

Signed-off-by: Fabrizio Demaria <[email protected]>
open-feature · Feb 2, 2024 · 5a2bc63 · 5a2bc63
1 parent 53a0908
commit 5a2bc63
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/android/src/main/java/dev/openfeature/sdk/events/EventHandler.kt b/android/src/main/java/dev/openfeature/sdk/events/EventHandler.kt
@@ -31,7 +31,7 @@ class EventHandler(dispatcher: CoroutineDispatcher) :
     ProviderStatus {
     private val sharedFlow: MutableSharedFlow<OpenFeatureEvents> = MutableSharedFlow()
     private val currentStatus: MutableStateFlow<OpenFeatureEvents> =
-        MutableStateFlow(OpenFeatureEvents.ProviderShutDown)
+        MutableStateFlow(OpenFeatureEvents.ProviderNotReady)
     private val job = Job()
     private val coroutineScope = CoroutineScope(job + dispatcher)
 
@@ -40,7 +40,7 @@ class EventHandler(dispatcher: CoroutineDispatcher) :
             sharedFlow.collect {
                 currentStatus.value = it
                 when (it) {
-                    is OpenFeatureEvents.ProviderShutDown -> {
+                    is OpenFeatureEvents.ProviderNotReady -> {
                         job.cancelChildren()
                     }
 

diff --git a/android/src/main/java/dev/openfeature/sdk/events/OpenFeatureEvents.kt b/android/src/main/java/dev/openfeature/sdk/events/OpenFeatureEvents.kt
@@ -1,8 +1,8 @@
 package dev.openfeature.sdk.events
 
 sealed interface OpenFeatureEvents {
+    object ProviderNotReady : OpenFeatureEvents
     object ProviderReady : OpenFeatureEvents
     data class ProviderError(val error: Throwable) : OpenFeatureEvents
     object ProviderStale : OpenFeatureEvents
-    object ProviderShutDown : OpenFeatureEvents
 }
diff --git a/android/src/test/java/dev/openfeature/sdk/EventsHandlerTest.kt b/android/src/test/java/dev/openfeature/sdk/EventsHandlerTest.kt
@@ -181,7 +181,7 @@ class EventsHandlerTest {
         val eventHandler = EventHandler(dispatcher)
         val provider = TestFeatureProvider(dispatcher, eventHandler)
 
-        Assert.assertEquals(OpenFeatureEvents.ProviderShutDown, provider.getProviderStatus())
+        Assert.assertEquals(OpenFeatureEvents.ProviderNotReady, provider.getProviderStatus())
 
         provider.emitReady()
 
@@ -201,6 +201,6 @@ class EventsHandlerTest {
 
         provider.shutdown()
 
-        Assert.assertEquals(OpenFeatureEvents.ProviderShutDown, provider.getProviderStatus())
+        Assert.assertEquals(OpenFeatureEvents.ProviderNotReady, provider.getProviderStatus())
     }
 }
diff --git a/android/src/test/java/dev/openfeature/sdk/TestFeatureProvider.kt b/android/src/test/java/dev/openfeature/sdk/TestFeatureProvider.kt
@@ -18,7 +18,7 @@ class TestFeatureProvider(
     }
 
     override fun shutdown() {
-        eventHandler.publish(OpenFeatureEvents.ProviderShutDown)
+        eventHandler.publish(OpenFeatureEvents.ProviderNotReady)
     }
 
     override fun onContextSet(oldContext: EvaluationContext?, newContext: EvaluationContext) {