Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: update minimum supported PHP version to 8.1 #109

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

tcarrio
Copy link
Member

@tcarrio tcarrio commented Dec 1, 2023

This PR

Updates the minimum supported version of the SDK to PHP 8.1
Introduces new PHP language features including readonly properties, enumerations,

  • minimum supported version of PHP is now 8.1
  • refactors pseudo-enums to true enums
  • utilizes readonly properties where applicable
  • utilizes array unpacking, e.g. [...$array] over array_merge($array)

Related Issues

Resolves #108

Follow-up Tasks

General TODOs before leaving DRAFT:

  • Resolve refactor failures in tests and static analysis
  • Update flagd provider to support breaking changes from major version release

How to test

Locally, you can run composer run test to execute the full test suite

Remotely, see GitHub CI runs

@tcarrio tcarrio changed the title Feat/php 81 min version feat!: update minimum supported PHP version to 8.1 Dec 1, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (82d58d2) 95.19% compared to head (21be2ee) 95.89%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #109      +/-   ##
============================================
+ Coverage     95.19%   95.89%   +0.69%     
+ Complexity      227      220       -7     
============================================
  Files            40       40              
  Lines           583      584       +1     
============================================
+ Hits            555      560       +5     
+ Misses           28       24       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for EOL PHP 8.0
1 participant